Skip to content
This repository was archived by the owner on Dec 17, 2024. It is now read-only.

Commit 792ea08

Browse files
committed
make default grid cells a smidgen bigger, to avoid squished inline text
Fixes #374
1 parent 5d18a38 commit 792ea08

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

app/plugins/modules/activation-visualizations/lib/cell.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ exports.renderCell = (returnTo, cell, activation, isFailure=!activation.response
5858
fdom.className = 'grid-oops-overlay'
5959
container.appendChild(fdom)
6060

61-
} else if (!options || options.zoom > 0) {
61+
} else if (!options || options.zoom >= 0) {
6262
// for larger zoom levels, and only for successful activations,
6363
// render the latency inside the cell
6464
const innerLabel = document.createElement('span')

app/plugins/modules/activation-visualizations/lib/grid.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ const _drawGrid = (options, {sidecar, leftHeader, rightHeader}, content, groupDa
287287
}
288288

289289
// and try to make the gridDom mostly squarish
290-
gridDom.querySelector('.grid-row').style.maxWidth = `${width * (zoomLevelForDisplay === 0 ? 2.5 : zoomLevelForDisplay === 1 ? 3 : zoomLevelForDisplay === 2 ? 4 : 0.75)}vw`
290+
gridDom.querySelector('.grid-row').style.maxWidth = `${width * (zoomLevelForDisplay === 0 ? 2.75 : zoomLevelForDisplay === 1 ? 3 : zoomLevelForDisplay === 2 ? 4 : 0.75)}vw`
291291

292292
let idx = 0
293293
group.activations.forEach(activation => {

app/plugins/modules/activation-visualizations/web/css/table.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -373,8 +373,8 @@
373373
}*/
374374
.activation-viz-plugin .grid-cell {
375375
/* square aspect ratio */
376-
width: 2.5vw;
377-
height: 2.5vw;
376+
width: 2.75vw;
377+
height: 2.75vw;
378378
}
379379
.activation-viz-plugin .zoom_1 .grid-cell {
380380
/* square aspect ratio */

0 commit comments

Comments
 (0)