Skip to content
This repository was archived by the owner on Dec 17, 2024. It is now read-only.

Commit 4023b7c

Browse files
committed
fix for improper header in summary and timeline when filtering by action
Fixes #743
1 parent 97ee5b7 commit 4023b7c

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

app/plugins/modules/activation-visualizations/lib/table.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -314,8 +314,8 @@ const _drawTable = (options, header, content, groupData, eventBus, sorter=defaul
314314
tableScrollContainer.className = 'data-table-scroll-container'
315315

316316
// header title
317-
const onclick = options.appName ? drilldownWith(viewName, () => repl.pexec(`app get "${options.appName}"`)) : undefined
318-
ui.addNameToSidecarHeader(sidecar, options.appName || titleWhenNothingSelected, undefined, onclick)
317+
const onclick = options.name ? drilldownWith(viewName, `app get "${options.name}"`) : undefined
318+
ui.addNameToSidecarHeader(sidecar, options.name || titleWhenNothingSelected, undefined, onclick)
319319

320320
// cache rows for redraw
321321
const rowMap = {}
@@ -400,7 +400,7 @@ const _drawTable = (options, header, content, groupData, eventBus, sorter=defaul
400400

401401
// drill down to grid view; note how we pass through a --name
402402
// query, to filter based on the clicked-upon row
403-
//row.onclick = drilldownWith(viewName, () => repl.pexec(`grid ${optionsToString(options)} --zoom 1 --name "${group.path}" ${splitOptions}`))
403+
//row.onclick = drilldownWith(viewName, `grid ${optionsToString(options)} --zoom 1 --name "${group.path}" ${splitOptions}`)
404404

405405
if (options.split) {
406406
const version = row.insertCell(-1)

app/plugins/modules/activation-visualizations/lib/timeline-histogram.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ const drawTimeline = (options, header) => activations => {
3838
content.style.width = 0 // ugh, chrome doesn't trigger a resize on shrink; see https://stackoverflow.com/a/7985973
3939

4040
// header title
41-
const onclick = options.appName ? drilldownWith(viewName, `app get "${options.appName}"`) : undefined
42-
ui.addNameToSidecarHeader(sidecar, options.appName || titleWhenNothingSelected, undefined, onclick)
41+
const onclick = options.name ? drilldownWith(viewName, `app get "${options.name}"`) : undefined
42+
ui.addNameToSidecarHeader(sidecar, options.name || titleWhenNothingSelected, undefined, onclick)
4343

4444
// add time range to the sidecar header
4545
const groupData = groupByAction(activations, Object.assign({ groupBySuccess: true }, options))

0 commit comments

Comments
 (0)