Skip to content
This repository was archived by the owner on Dec 17, 2024. It is now read-only.

Commit 04c9905

Browse files
committed
fix buggy transition from timeline to summary
Fixes #946
1 parent f970cf0 commit 04c9905

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

app/plugins/modules/activation-visualizations/lib/util.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ exports.optionsToString = (options, except) => {
398398
let str = ''
399399
for (let key in options) {
400400
// underscore comes from minimist
401-
if (key !== '_' && options[key] !== undefined && key !== 'name' && key !== 'theme'
401+
if (key !== '_' && options[key] !== undefined && key !== 'name' && key !== 'theme' && key !== 'timeline' && key !== 't'
402402
&& (!except || !except.find(_ => _ === key))) {
403403
const dash = key.length === 1 ? '-' : '--',
404404
prefix = options[key] === false ? 'no-' : '', // e.g. --no-help

tests/tests/passes/05/activation-grid-view.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,4 +286,13 @@ describe('Activation grid visualization', function() {
286286
it('should open grid as timeline with grid -t', () => cli.do('grid -t', this.app)
287287
.then(cli.expectOK)
288288
.catch(common.oops(this)))
289+
290+
it('should open grid as timeline with grid -t, then switch to summary', () => cli.do('grid -t', this.app)
291+
.then(cli.expectOK)
292+
.then(() => this.app.client.click(ui.selectors.SIDECAR_MODE_BUTTON('summary')))
293+
.then(() => this.app.client.waitUntil(() => {
294+
return this.app.client.getText('.sidecar-header-icon')
295+
.then(txt => txt.toLowerCase() === 'summary')
296+
}))
297+
.catch(common.oops(this)))
289298
})

0 commit comments

Comments
 (0)