Bug: Neovim 0.11 rendering bug

[reybits]

RTFM Checklist

• I have searched exisiting issues / discussions
• I have read the Wiki including the Advanced section
• I have read man fzf / I am well versed in shell fzf

Operating system

macOS

Shell

zsh

Neovim version (nvim --version)

NVIM v0.11.0

Fzf version (fzf --version)

0.60.3 (brew)

Output of :lua print(os.getenv('FZF_DEFAULT_OPTS'))

--height 75% --layout=reverse --border --no-hscroll --info inline-right

Is the problem reproducible with mini.sh?

• My issue is reproducible with mini.sh
• My issue IS NOT reproducible with mini.sh
• I have not tested with mini.sh (not relevant, requires LSP, Windows, etc)

Fzf-lua configuration

require('fzf-lua').setup({
            -- profile
            "hide", -- or "telescope",

            winopts = {
                width = 0.96,
                height = 0.96,
                preview = {
                    layout = "vertical",
                    vertical = "up:70%",
                },
            },
            keymap = {
                builtin = {
                    false,
                    ["<F1>"] = "toggle-help",
                    ["<M-/>"] = "toggle-help",

                    ["<M-S-f>"] = "toggle-fullscreen",

                    ["<M-p>"] = "toggle-preview",
                    ["<M-w>"] = "toggle-preview-wrap",

                    ["<M-c>"] = "toggle-preview-cw",
                    ["<M-S-c>"] = "toggle-preview-ccw",

                    ["<C-d>"] = "preview-page-down",
                    ["<C-u>"] = "preview-page-up",
                },
                fzf = {
                    false,
                    ["alt-a"] = "toggle-all",
                    ["alt-g"] = "first",
                    ["alt-G"] = "last",
                },
            },
            files = {
                hidden = false,
            },
            buffers = {
                prompt = "❯ ",
            },
            keymaps = {
                prompt = "❯ ",
                winopts = { preview = { hidden = true } },
            },
            actions = {
                files = {
                    -- true, -- if set to true, enables default settings.

                    ["enter"] = actions.file_edit_or_qf,
                    ["ctrl-q"] = actions.file_sel_to_qf,
                    ["alt-f"] = actions.toggle_follow,
                    ["alt-h"] = actions.toggle_hidden,
                    ["alt-i"] = actions.toggle_ignore,
                    ["ctrl-s"] = actions.file_split,
                    ["ctrl-v"] = actions.file_vsplit,
                },
            },
            fzf_opts = {
                ["--layout"] = "default",
                ["--history"] = vim.fn.stdpath("data") .. "/fzf-lua-history",
            },
            previewers = {
                builtin = {
                    extensions = {
                        -- neovim terminal only supports `viu` block output
                        ["png"] = { "viu", "-b" },
                        ["jpg"] = { "viu", "-b" },
                        ["gif"] = { "viu", "-b" },
                        ["jpeg"] = { "viu", "-b" },
                        -- ["jpg"] = { "ueberzug" },
                    },
                    -- When using 'ueberzug' we can also control the way images
                    -- fill the preview area with ueberzug's image scaler, set to:
                    --   false (no scaling), "crop", "distort", "fit_contain",
                    --   "contain", "forced_cover", "cover"
                    -- For more details see:
                    -- https://github.com/seebye/ueberzug
                    -- ueberzug_scaler = "cover",
                },
            },

})

Describe the bug / steps to reproduce

Hello! First of all, thank you for the great plugin!

After updating to Neovim 0.11, I consistently experience rendering issues in fzf-lua. However, no such issues occur with FZF in the terminal. Moreover, everything works fine in Neovim 0.10.

[reybits]

Here are several screenshots illustrating the rendering issue.

[ibhagwan]

Here are several screenshots illustrating the rendering issue.

Not sure what I'm looking at here, the first screenshot displays both a double input line as well as something that looks like it's coming from an indent line plugin?

What's wrong with the second screenshot I'm not sure, highlights?

In any event this seems either upstream, double input would be an issue with neovim's term and the highlight issue would be config related (highlights).

Not much I can do here.

[reybits]

On the first screenshot, you can see that the list window has shifted upward, creating a “double” input field.

On the second screenshot, you can see fragments of file names appearing while navigating (notice “luaa,” “luauaua,” etc.).

Am I correct in assuming that the issue is on Neovim 0.11’s side rather than fzf-lua or my configuration?

[phanen]

Yes, I reproduced.

      require('fzf-lua').setup({
        winopts = { preview = { layout = 'vertical', vertical = 'up:70%',  } },
        fzf_opts = { ['--layout'] = 'default' },
      })

Looks very like https://github.com/kevinhwang91/nvim-bqf/blob/ee9c8c842e227462c27b0d8a1eb30845d226f874/lua/bqf/preview/session.lua#L188. But this also happen on nvim <0.11.

I related to the height of fzf term win.

EDIT: neovim/neovim@8df6736.

[ibhagwan]

On the first screenshot, you can see that the list window has shifted upward, creating a “double” input field.

On the second screenshot, you can see fragments of file names appearing while navigating (notice “luaa,” “luauaua,” etc.).

I see, ty.

In any event, this is a rendering issue outside of fzf-lua’s control, once fzf-lua starts the terminal process it has no more control over rendering.

@phanen mentioned:

I related to the height of fzf term win.

Maybe your FZF_DEFAULT_OPTS combo with neovim 0.11 are causing this? Can you try running the below command and try again?

:lua vim.env.FZF_DEFAULT_OPTS=nil

[phanen]

No, I erase env before start neovim.

Can be reproduce by mini.sh (with the config above, maybe ensure the fzf term height is small?):

FZF_DEFAULT_OPTS= FZF_DEFAULT_OPTS_FILE= bash scripts/mini.sh

• FzfLua files.
• Maybe you need to continuously press ctrl-j/ctrl-k many times to see this happened.

If disable reflow in neovim then it don't happened: neovim/neovim@8df6736.

Either libtermkey bug or fzf.
But I if replace --preview with other trivial command then this also don't happen...

[miklhh]

I wonder what causes this issue. I have the exact same rendering problems and it is really bugging me.

[phanen]

@miklhh This can be workaround by disable scrollbar and treesitter-context (which create new float window I think, as mentioned in nvim-bqf's comment).

Or just don't use --layout=default but use --layout=reverse (I don't know why)

Or use ffi to disable relfow on fzf term

[ibhagwan]

If disable reflow in neovim then it don't happened: neovim/neovim@8df6736.

Should we open an issue upstream or maybe there is one already?