Why is fzf preview window height smaller than expected?

[nothankyouzzz]

I'm using LazyVim and noticed some unexpected behavior with fzf-lua:

As shown in the screenshot above, the preview window has a height of only 8, even though it is configured to be 15 lines. Because of this unexpected preview height, the select menu is also misaligned, as it consumes the remaining allocated space.

Here’s the relevant Lua configuration:

ui_select = function(fzf_opts, items)
  local padding = #items == 0 and 3 or 4

  return vim.tbl_deep_extend("force", fzf_opts, {
    prompt = " ",
    winopts = {
      title = " " .. vim.trim((fzf_opts.prompt or "Select"):gsub("%s*:%s*$", "")) .. " ",
      title_pos = "center",
    },
  }, fzf_opts.kind == "codeaction" and {
    winopts = {
      layout = "vertical",
      -- height is number of items minus 15 lines for the preview, with a max of 80% screen height
      height = math.floor(math.min(vim.o.lines * 0.8 - 16, #items + 4) + 0.5) + 16,
      width = 0.5,
      preview = not vim.tbl_isempty(LazyVim.lsp.get_clients({ bufnr = 0, name = "vtsls" })) and {
        layout = "vertical",
        vertical = "down:15,border-top",
        hidden = "hidden",
      } or {
        layout = "vertical",
        vertical = "down:15,border-top",
      },
    },
  } or {
    winopts = {
      width = 0.5,
      -- height is number of items, with a max of 80% screen height
      height = math.floor(math.min(vim.o.lines * 0.8, #items + padding) + 0.5),
    },
  })
end

[nenahp]

iirc only percentage work now
15 should be replaced by a percentage

[nothankyouzzz]

Isn't that an issue should be fixed, or at least be supported as a feat?
numeric size is supported by fzf.

[nenahp]

yeah, technically no reason don't support it
i ll take a look

[nenahp]

#2334