Custom buffer picker not closing fzf-lua process

[Emille1723]

This gif shows the header and the list data not updating after selecting a different file to edit

This gif shows that the header and data only update after using fzf.files which is closing its process properly after a file is selected

I have a custom picker that gets its list from this block

    local currBuf = vim.api.nvim_get_current_buf()
    local function list_all_buffers()
        -- local bufs = vim.api.nvim_list_bufs()
        local bufs = loadedBufs
        local listed_bufs = {}
        for _, buf in ipairs(vim.api.nvim_list_bufs()) do
            if
                vim.fn.buflisted(buf) == 1
                and vim.api.nvim_buf_is_valid(buf)
                -- this was causing some problems with not showing some saved buffers in sessions
                -- and vim.api.nvim_buf_is_loaded(buf)
                and currBuf ~= buf
            then
                table.insert(listed_bufs, buf)
            end
        end
        Buffers = listed_bufs
        return listed_bufs
    end

    for _, bufid in ipairs(all_bufs) do
        local bufInfo = vim.fn.getbufinfo(bufid)
        for _, b in ipairs(bufInfo) do
            -- next steps
            -- extract the name
            -- split into, cwd, rel path & name
            -- store bufid/bufnr
            -- add a check to see if the file is modified
            -- add custom modified indicator
            local file_path = b["name"]
            local bufnr = b["bufnr"]
            local file_name = vim.fn.fnamemodify(file_path, ":t")
            local file_type = vim.api.nvim_get_option_value("filetype", { buf = bufnr })
	        local iconRef, file_color = webDevIcons.get_icon_color_by_filetype(file_type) -- fetch icon, colour by filetype
            local path_wo_cwd = file_path:gsub(cwd, ''):gsub("^/", '')
            local rel_path_wo_file_name = path_wo_cwd:match("(.*/)"):gsub("/$", '') -- print everything before the last / including the last /
            local is_modded = vim.api.nvim_get_option_value("modified", { buf = bufnr }) and " " .. icons.fileState.modified or ''
            local line_number = vim.api.nvim__buf_stats(bufnr).current_lnum
            local entry = string.format("%s |%s |%s%s%s %s%s%s %s %s%s%s%s:%s%s%s%s", 
                file_path, 
                bufnr, 
                navajo_white, is_modded, RESET, 
                helpers.hex_to_ansi(file_color or "#ffffff"), iconRef, RESET,
                file_name, 
                ITALIC, periwinkle, rel_path_wo_file_name, RESET, 
                white, RESET,
                pastelGreen, line_number, RESET)
            table.insert(bufs_data, entry)
        end
    end

Here's the fzf_exec

    return fzf_lua.fzf_exec(
        -- function(fzf_cb)
        --     for _, line in ipairs(Buffers) do
        --         fzf_cb(line)
        --     end
        --     fzf_cb(nil)
        -- end,
        Buffers,
        {
            actions = {
                false,
                ["enter"] = 
                    -- fn = function(selected, optss)
                    function(selected, optss)
                        local entry = selected[1]
                        if not entry then return end
                        -- local bpath = entry:gsub("(|.*)", ""):gsub('^%s*(.-)%s*$', '%1') -- remove everything after the first |
                        local bpath = entry:match("^(.-)%s*|")
                        -- bpath = vim.fn.trim(bpath)
                        bpath = vim.fn.expand(vim.fn.trim(bpath))

                        if vim.fn.filereadable(bpath) == 1 then
                            -- actions.file_edit({bpath}, optss)
                            return require("fzf-lua.actions").file_edit({ bpath }, optss)
                            -- require'fzf-lua'.actions.file_edit({bpath}, optss)
                            -- return vim.cmd("e " .. bpath)
                            -- return vim.cmd("silent! e! " .. bpath)
                            -- vim.cmd("edit " .. vim.fn.fnameescape(bpath))
                        end
                    end
                ,
                ["ctrl-x"] = {
                    fn = function(buf, opts)
                        buf = buf[1]
                        local buf_nr = string.match(buf, "%|([^|]+)%|"):gsub('^%s*(.-)%s*$', '%1') -- get everything between 1st and 2nd |
                        local fallback_nr = 0
                        local fallback_nr1 = 0

                        -- we're working with the list we passed to the picker
                        -- so I want to remove the item from the list as well
                        for i, buff in ipairs(Buffers) do
                            local buff_nr = string.match(buff, "%|([^|]+)%|"):gsub('^%s*(.-)%s*$', '%1') -- get everything between 1st and 2nd |
                            if tonumber(buf_nr) == tonumber(buff_nr) then
                                table.remove(Buffers, i)
                            end
                        end

                        -- delete the buffer
                        -- vim.api.nvim_buf_delete(tonumber(buf_nr), { unload = true, force = true })
                        vim.cmd("silent! bwipeout!" .. buf_nr)

                        -- close the picker if list is now empty after action
                        if tonumber(#Buffers) <= 0 then
                            return vim.api.nvim_input('<C-c>')
                        end
                    end,
                    reload = true
                }
            },
            fzf_opts = {
                ['--info'] = 'hidden',
                ['--header'] = string.format(" %s  %s%s \n %s%s%s %s%s %s%s | 󰈤 %d", 
                    light_blue, vim.uv.cwd():gsub(os.getenv("HOME"), ''):gsub("^/", ''), RESET, 
                    navajo_white, modified, RESET, 
                    purple, curr_iconRef, currBufName, RESET, 
                    (#Buffers + 1)),
                ['--algo'] = 'v2',
                ['--tiebreak'] = 'begin', -- choose the first match inline
                ['--delimiter'] = '|',
                ['--with-nth'] = '-1..', 
            },
            cwd = vim.uv.cwd(),
            keymap = {
                builtin = {
                    ["<C-d>"] = "preview-page-down",
                },
                fzf = {
                    ["ctrl-d"] = "preview-page-down",
                }
            }
    })

it goes to the file but the picker doesn't close until I use another like builtin files
I'm at my wits end here

any help is very much appreciated

[nenahp]

Cannot reproduce, you'd better provide a minimal repro.

[Emille1723]

Thanks, no problem

Ok, a few things to try, first see if your analysis is accurate and the process is indeed not closing or your list fed to fzf-lua isn't updated.

1. Run your picker, press enter
2. Run :ls! and see if fzf-lua has a lingering process, see example with the hide profile:

3. I suspect something different, your process is closing properly but your list isn't updated properly beforehand 4. Restore your code to the commented one you have and add a `vim.print(Buffers)`, if your list isn't updated, find out why (use `:messages` to see the output of `vim.print`):

return fzf_lua.fzf_exec(
        function(fzf_cb)
            vim.print(Buffers)
            for _, line in ipairs(Buffers) do
                fzf_cb(line)
            end
            fzf_cb(nil)
        end,

I don't see a fzf-lua buffer so I think you're right
my header and list are not updating properly
I updated the code to look like this, yet my issue continues
I may have just written bad code

local function list_all_buffers()
    local currBuf = vim.api.nvim_get_current_buf()
    local listed_bufs = {}
    -- vim.notify(" start: " .. os.time() .. vim.inspect(listed_bufs))
    for _, buf in ipairs(vim.api.nvim_list_bufs()) do
        if
            vim.fn.buflisted(buf) == 1
            and vim.api.nvim_buf_is_valid(buf)
            -- this was causing some problems with not showing some saved buffers in sessions
            -- and vim.api.nvim_buf_is_loaded(buf)
            and currBuf ~= buf
        then
            vim.cmd("silent! buffer! " .. buf)
            -- vim.cmd("silent! badd! " .. buf)
            table.insert(listed_bufs, buf)
        end
    end
    -- vim.notify("end: " .. os.time() .. tostring(#listed_bufs))
    return listed_bufs
end

local builtin = require("fzf-lua.previewer.builtin")

-- Inherit from the "buffer_or_file" previewer
local MyPreviewer = builtin.buffer_or_file:extend()

function MyPreviewer:new(o, opts, fzf_win)
    MyPreviewer.super.new(self, o, opts, fzf_win)
    setmetatable(self, MyPreviewer)
    return self
end

function MyPreviewer:parse_entry(entry_str)
    local buf_info = entry_str:match("^[^|]*|[^|]*|")
    local buf_path = entry_str:gsub('(|.*)', ''):gsub('^%s*(.-)%s*$', '%1')  -- remove everything after the first | then remove whitespace
    local buf_nr = string.match(entry_str, "%|([^|]+)%|"):gsub('^%s*(.-)%s*$', '%1') -- get everything between 1st and 2nd |
    local line = vim.api.nvim__buf_stats(tonumber(buf_nr)).current_lnum
    return {
        path = buf_path,
        line = line or 1,
        col = false
    }
end

local function strip_ansi(str)
    return str:gsub('\27%[%d+[;%d]*m', '')
end

local ITALIC = '\27[3m'
local RESET = '\27[0m'
local cerulean = '\27[38;2;66;165;245m'
local heliotrope = '\27[38;2;240;147;249m' 
local purple = '\27[38;2;189;147;249m'
local light_blue = '\27[38;2;111;201;244m'
local pastelGreen = '\27[38;2;144;238;144m'
local periwinkle = '\27[38;2;162;164;252m' 
local navajo_white = '\27[38;2;255;216;175m' 
local white = '\27[38;2;255;255;255m' 

local function build_list(all_bufs)
    -- my attempt at building my own buffer picker how I want it
    local bufs_data = {}
    local cwd = vim.uv.cwd()
    for _, bufid in ipairs(all_bufs) do
        local bufInfo = vim.fn.getbufinfo(bufid)
        for _, b in ipairs(bufInfo) do
            -- next steps
            -- extract the name
            -- split into, cwd, rel path & name
            -- store bufid/bufnr
            -- add a check to see if the file is modified
            -- add custom modified indicator
            local file_path = b["name"]
            local bufnr = b["bufnr"]
            local file_name = vim.fn.fnamemodify(file_path, ":t")
            local file_type = vim.api.nvim_get_option_value("filetype", { buf = bufnr })
            local iconRef, file_color = webDevIcons.get_icon_color_by_filetype(file_type) -- fetch icon, colour by filetype
            local path_wo_cwd = file_path:gsub(cwd, ''):gsub("^/", '')
            local rel_path_wo_file_name = path_wo_cwd:match("(.*/)"):gsub("/$", '') -- print everything before the last / including the last /
            local is_modded = vim.api.nvim_get_option_value("modified", { buf = bufnr }) and " " .. icons.fileState.modified or ''
            local line_number = vim.api.nvim__buf_stats(bufnr).current_lnum
            local entry = string.format("%s |%s |%s%s%s %s%s%s %s %s%s%s%s:%s%s%s%s", 
                file_path, 
                bufnr, 
                navajo_white, is_modded, RESET, 
                helpers.hex_to_ansi(file_color or "#ffffff"), iconRef, RESET,
                file_name, 
                ITALIC, periwinkle, rel_path_wo_file_name, RESET, 
                white, RESET,
                pastelGreen, line_number, RESET)
            table.insert(bufs_data, entry)
        end
    end
    return bufs_data
end

local function buildHeader(bufs_data)
    -- local currBuf = vim.api.nvim_get_current_buf()
	-- local currBufName = vim.fs.normalize(vim.fn.expand '%:t' --[[@as string]]) -- file name
    -- local currBufName = vim.fn.bufname(currBuf)
    local currBufFileName = vim.api.nvim_buf_get_name(0)
    local currBufName = vim.fn.fnamemodify(currBufFileName, ":t")

	-- vim.notify(currBufName)
	local currBufFt = vim.api.nvim_get_option_value("filetype", { buf = 0 })
	local curr_iconRef, _ = webDevIcons.get_icon_color_by_filetype(currBufFt)
    local modified = vim.api.nvim_get_option_value("modified", { buf = 0 }) and " " .. icons.fileState.modified .. "" or ''
    return string.format(" %s  %s%s \n %s%s%s %s%s %s%s | 󰈤 %d", 
        light_blue, vim.uv.cwd():gsub(os.getenv("HOME"), ''):gsub("^/", ''), RESET, 
        navajo_white, modified, RESET, 
        purple, curr_iconRef, currBufName, RESET, 
        (#bufs_data + 1))
end

local function open_custom_buffer()
    vim.cmd([[ bufdo! filetype detect ]]) -- ensure that the filetypes are loaded
    local loadedBufs = helpers.listBuffers()
    local bufCount = #loadedBufs

    if bufCount <= 1 then
        if
            bufCount <= 0
        then
            return vim.notify(
                "No files are currently open!  ",
                vim.log.levels.ERROR,
                {
                    title = "buffer list",
                    icon = icons.emojis.stop1
                }
            )
        end
        return vim.notify(
            "At most 1 file is currently open!",
            vim.log.levels.WARN,
            {
                title = "buffer list",
                icon = icons.diagnostics.warn
            }
        )
    end

    -- local all_bufs = list_all_buffers(currBuf)
    local all_bufs = list_all_buffers()
    local bufs_data = build_list(all_bufs)
    -- Buffers = bufs_data

    return vim.defer_fn(function()
        fzf_lua.fzf_exec(
            function(fzf_cb)
                vim.print(bufs_data)
                for _, line in ipairs(bufs_data) do
                    fzf_cb(line)
                end
                fzf_cb(nil)
            end,
            -- bufs_data,
            {
                previewer = MyPreviewer,
                actions = {
                    ["enter"] = 
                        function(selected, optss)
                            -- local entry = selected[1]
                            -- if not entry then return end
                            --
                            -- -- local bpath = entry:gsub("(|.*)", ""):gsub('^%s*(.-)%s*$', '%1') -- remove everything after the first |
                            -- local bpath = entry:match("^(.-)%s*|")
                            -- -- bpath = vim.fn.trim(bpath)
                            -- bpath = vim.fn.expand(vim.fn.trim(bpath))
                            -- local buf_nr = string.match(entry, "%|([^|]+)%|"):gsub('^%s*(.-)%s*$', '%1') -- get everything between 1st and 2nd |
                            --
                            -- if vim.fn.filereadable(bpath) == 1 then
                            --     bufs_data = {}
                            --     -- vim.api.nvim_set_current_buf(tonumber(buf_nr))
                            --     return actions.file_edit({bpath}, optss)
                            --     -- return require("fzf-lua.actions").file_edit({ bpath }, optss)
                            --     -- require'fzf-lua'.actions.file_edit({bpath}, optss)
                            --     -- return vim.cmd("e " .. bpath)
                            --     -- return vim.cmd("silent! e! " .. bpath)
                            --     -- vim.cmd("edit " .. vim.fn.fnameescape(bpath))
                            -- end
                            local entry = selected[1]
                            if not entry then return end

                            local bpath = entry:match("^(.-)%s*|")
                            bpath = vim.fn.expand(vim.fn.trim(bpath))

                            if vim.fn.filereadable(bpath) == 1 then
                                return require("fzf-lua.actions").file_edit({ bpath }, optss)
                            end
                        end
                    ,
                    ["ctrl-x"] = {
                        fn = function(selected, opts)
                            local entry = selected[1]
                            local buf_nr = string.match(entry, "%|([^|]+)%|"):gsub('^%s*(.-)%s*$', '%1') -- get everything between 1st and 2nd |

                            -- we're working with the list we passed to the picker
                            -- so I want to remove the item from the list as well
                            for i, buff in ipairs(bufs_data) do
                                local buff_nr = string.match(buff, "%|([^|]+)%|"):gsub('^%s*(.-)%s*$', '%1') -- get everything between 1st and 2nd |
                                if tonumber(buf_nr) == tonumber(buff_nr) then
                                    table.remove(bufs_data, i)
                                end
                            end

                            -- delete the buffer
                            -- vim.api.nvim_buf_delete(tonumber(buf_nr), { unload = true, force = true })
                            vim.cmd("silent! bwipeout!" .. buf_nr)

                            -- close the picker if list is now empty after action
                            if tonumber(#bufs_data) <= 0 then
                                return vim.api.nvim_input('<C-c>')
                            end
                        end,
                        reload = true
                    }
                },
                fzf_opts = {
                    ['--info'] = 'hidden',
                    ['--header'] = buildHeader(bufs_data),
                    ['--algo'] = 'v2',
                    ['--tiebreak'] = 'begin', -- choose the first match inline
                    ['--delimiter'] = '|',
                    ['--with-nth'] = '-1..', 
                },
                keymap = {
                    builtin = {
                        ["<C-d>"] = "preview-page-down",
                    },
                    fzf = {
                        ["ctrl-d"] = "preview-page-down",
                    }
                }
            })
    end, 10)
end
keymap.set("n", "<leader>ls", function() open_custom_buffer() end, opts)

[Emille1723]

I think the current buffer isn't updating
It's either that or the data is being made stale somewhere that I haven't found as yet

[ibhagwan]

my header and list are not updating properly
I think the current buffer isn't updating

Use vim.print to debug and see why the buffer list isn't updating, you may just need to call your updating function somwhere else

[Emille1723]

I think the current buffer isn't updating It's either that or the data is being made stale somewhere that I haven't found as yet

so the current buffer info was not consistent
I fetched it before calling the custom picker and passed that info to it
That did the trick. Thanks alot for your help

 keymap.set("n", "<leader>ls", function() 
    local currBuf = vim.api.nvim_get_current_buf()
    local currFilePath = vim.api.nvim_buf_get_name(currBuf)
    local currBufName = vim.fn.fnamemodify(currFilePath, ":t")
    local currBufData = { currBuf, currFilePath, currBufName }
    return open_custom_buffer(currBufData) 
end, opts)