[HELP] Can't get my custom picker to use builtin preview instead of less

[qiine]

I am trying to build a simple "dictionary browser" of sorts using dict and a word database.
It mostly works except the preview seems to use less instead of the builtin.
(I get for ex 1/2281 to the top right of the preview, for a long text and no numbers, no scrollbar etc..)

I don't get why? other pickers works fine..
Could someone help me?

    fzfl.dictionary = function()
            fzfl.fzf_exec("cat /etc/dictionaries-common/words", {
                prompt = "Word> ",
                preview = function(sel)
                    local item = table.concat(sel, "")
                    local res = vim.system({"dict", "-C", "-s", "exact", "-d", "gcide", item},{text=true}):wait()
                    return vim.split(res.stdout,"\n", {plain=true})
                end,
                winopts = {
                    height = 0.80, width = 1.00,
                    preview = {
                        layout = "horizontal",
                        horizontal = "right:70%",
                        wrap = true,
                    },
                },
                actions = {
                    ["default"] = function(selected)
                        local out = table.concat(selected, "")
                        vim.cmd("norm! i"..out)
                    end,
                },
            })
        end

relevant config bits:

winopts = {
                title_pos    = "center",
                border       = "rounded", --single
                height       = 0.75,         -- window height
                width        = 1,            -- window width
                row          = 0.50,         -- window row position (0=top, 1=bottom)
                col          = 0.51,         -- window col position (0=left, 1=right)
                backdrop     = 100,  --opacity
                preview = {
                    default = "builtin",
                    border = "border",
                    layout = "horizontal",
                    horizontal = "right:47%",
                    --hidden = "hidden",
                },
            },

[nenahp]

It mostly works except the preview seems to use less instead of the builtin.

Yes, it's expected, to custom "builtin" you can read the code of "fzf-lua.test.previewer":

require('fzf-lua').fzf_exec({ 'a' }, { previewer = require('fzf-lua.test.previewer') })

[qiine]

oh ok! I actually managed to do it!

local builtin = require("fzf-lua.previewer.builtin")

local function make_preview(preview_lines)
    local M = builtin.base:extend()

    function M:new(o, opts, fzf_win)
        M.super.new(self, o, opts, fzf_win)
        setmetatable(self, M)
        return self
    end

    function M:populate_preview_buf(entry)
        local buf = self:get_tmp_buffer()

        local lines = preview_lines(entry)
        vim.api.nvim_buf_set_lines(buf, 0, -1, false, lines)

        self:set_preview_buf(buf)
        self.win:update_preview_title(tostring(entry))
    end

    return M
end

fzfl.dictionary = function()
        fzfl.fzf_exec("cat /etc/dictionaries-common/words", {
        prompt = "Word> ",
        previewer = function()
            return make_preview(function(entry)
                local res = vim.system({"dict", "-C", "-s", "exact", "-d", "gcide", entry}, { text = true }):wait()
                return vim.split(res.stdout, "\n")
            end)
        end,
        winopts = {
            height = 0.80, width = 1.00,
            preview = {
                layout = "horizontal",
                horizontal = "right:75%",
                wrap = true,
                winopts = {                 
                    number = false,
                },
            },
        },
        actions = {
            ["default"] = function(selected)
                local out = table.concat(selected, "")
                vim.cmd("norm! i"..out)
            end,
        },
    })
end

its kinda above my level though.. I am not sure if this is elegant?

[ibhagwan]

its kinda above my level though.. I am not sure if this is elegant?

As elegant as it gets :)

[ibhagwan]

oh ok! I actually managed to do it!

local builtin = require("fzf-lua.previewer.builtin")

local function make_preview(preview_lines)
    local M = builtin.base:extend()

    function M:new(o, opts, fzf_win)
        M.super.new(self, o, opts, fzf_win)
        setmetatable(self, M)
        return self
    end

    function M:populate_preview_buf(entry)
        local buf = self:get_tmp_buffer()

        local lines = preview_lines(entry)
        vim.api.nvim_buf_set_lines(buf, 0, -1, false, lines)

        self:set_preview_buf(buf)
        self.win:update_preview_title(tostring(entry))
    end

    return M
end

fzfl.dictionary = function()
        fzfl.fzf_exec("cat /etc/dictionaries-common/words", {
        prompt = "Word> ",
        previewer = function()
            return make_preview(function(entry)
                local res = vim.system({"dict", "-C", "-s", "exact", "-d", "gcide", entry}, { text = true }):wait()
                return vim.split(res.stdout, "\n")
            end)
        end,
        winopts = {
            height = 0.80, width = 1.00,
            preview = {
                layout = "horizontal",
                horizontal = "right:75%",
                wrap = true,
                winopts = {                 
                    number = false,
                },
            },
        },
        actions = {
            ["default"] = function(selected)
                local out = table.concat(selected, "")
                vim.cmd("norm! i"..out)
            end,
        },
    })
end

its kinda above my level though.. I am not sure if this is elegant?

Btw, if you really wanted to make it pretty you can parse the vim.system output and write something nice in markdown, then set the preview filetype to markdown and you’ll get syntax highlighting, if you have render-markdown or markview you may even get nice rendering like in #1546