Why did ibhagwan remove callbacks such as "fn_post_fzf"?

[lbrayner]

Hey @ibhagwan , why did you remove callbacks such as fn_post_fzf? I was using it to filter the history file and remove duplicate entries (https://github.com/lbrayner/init.lua/blob/master/lua/lbrayner/fzf-lua.lua#L117).

[ibhagwan]

Hey @ibhagwan , why did you remove callbacks such as fn_post_fzf? I was using it to filter the history file and remove duplicate entries (https://github.com/lbrayner/init.lua/blob/master/lua/lbrayner/fzf-lua.lua#L117).

I found it was obscure and nobody used it and it wanted to simplify the code as part of the big refactor, since basically all fzf-lua content types are converted to string shell commands this enabled a lot of goodies like the new global picker / combining pickers.

As for these functions there are better alternatives, for example, filtering can be done in fn_transform by returning nil and post callbacks can be easily done on winopts.on_close or a custom fn_selected depending on your callback timing needs:

fzf-lua/lua/fzf-lua/providers/lsp.lua

Lines 458 to 461 in e40e233

	opts.fn_selected = function(...)
	fn_cancel_all(opts)
	actions.act(...)
	end

Over the years I’ve mostly avoided breaking changes at all cost but this was a minimal breaking change (rarely used) for a great benefit.

[lbrayner]

Nice! Using winopts.on_close dit it, thank you! Keep up the good work.

[ibhagwan]

Nice! Using winopts.on_close dit it, thank you! Keep up the good work.

Ty @lbrayner!