Combination of oldfiles and files

[elanmed]

Hey all, I've been working on a function that's a combination of oldfiles and files: oldfiles in the target cwd listed first, everything from files after. I think this can function like a barebones version of telescope-frecency.nvim or snacks smart. Open to feedback!

If I'm understanding all the coroutine logic correctly, this code should:

1. Open the picker ui immediately
2. Iterate through the oldfiles. If an oldfile is readable (i.e. not an oil buffer), it'll be added to the picker. By using coroutine.wrap, each oldfile can be added to the ui as its processed instead of waiting for the entire loop to finish.
3. Start a plenary job to find files in the current cwd. As the stdout stream is output, each file in the stdout is added to the ui.

local fzf_lua = require "fzf-lua"
local Job = require "plenary.job"

local function old_and_all_files(opts)
  opts = opts or {}
  local cwd = opts.cwd or vim.fn.getcwd()

  local contents = function(fzf_cb)
    local seen = {}

    -- based on https://github.com/ibhagwan/fzf-lua/blob/main/lua/fzf-lua/providers/oldfiles.lua#L47
    coroutine.wrap(function()
      local co = coroutine.running()

      for _, oldfile in ipairs(vim.v.oldfiles) do
        -- TODO: fzf_lua.oldfiles has more robust checks
        -- https://github.com/ibhagwan/fzf-lua/blob/main/lua/fzf-lua/providers/oldfiles.lua#L23
        local readable = vim.fn.filereadable(oldfile) == 1

        if readable and vim.startswith(oldfile, cwd) then
          local relative_file = oldfile:sub(#cwd + 2) -- remove leading /
          if seen[relative_file] then return end
          seen[relative_file] = true

          local entry = fzf_lua.make_entry.file(relative_file, opts)
          if not entry then return end
          fzf_cb(entry, function(err)
            coroutine.resume(co)
            if err then fzf_cb(nil) end
          end)
          coroutine.yield()
        end
      end

      Job:new {
        command = "fd",
        args = { "--type", "f", },
        on_stdout = function(err, file)
          if err then return end
          if seen[file] then return end
          seen[file] = true
          local entry = fzf_lua.make_entry.file(file, opts)

          fzf_cb(entry)
        end,
        on_exit = function()
          fzf_cb(nil)
        end,
      }:start()
    end)()
  end

  local default_opts = { actions = fzf_lua.defaults.actions.files, fzf_opts = { ["--multi"] = true, }, }
  local fzf_exec_opts = vim.tbl_extend("force", default_opts, opts)
  fzf_lua.fzf_exec(contents, fzf_exec_opts)
end

[ibhagwan]

If I'm understanding all the coroutine logic correctly, this code should:

Your logic is sound but I’m not sure how much you want to invest in this, once #2152 is merged (still needs work but it’s getting there), you’ll be able to combine pickers as easy as :FzfLua combine pickers=oldfiles,files (I’m not 100% set on the syntax/naming but something like this).

[elanmed]

Thanks for confirming! I'll subscribe to the PR, combining pickers natively would be awesome 🙏