Same keybinds for multiple options :(

[halshar]

Hello,

I'm planning to migrate to fzf-lua from telescope and want to use same bindings but from what I've read and experimented I've to define same mappings at multiple places. Following is my config using lazy package manager

return {
	"ibhagwan/fzf-lua",
	dependencies = { "nvim-tree/nvim-web-devicons" },
	config = function()
		local actions = require("fzf-lua").actions
		require("fzf-lua").setup({
			"ivy",
			defaults = {
				git_icons = false,
				file_icons = false,
				color_icons = false,
			},
			files = {
				actions = {
					["enter"] = actions.file_edit,
					["ctrl-x"] = actions.file_split,
					["ctrl-s"] = actions.file_vsplit,
				},
			},
			buffers = {
				show_unloaded = false,
				sort_lastused = false,
				actions = {
					["enter"] = actions.file_edit,
					["ctrl-x"] = actions.file_split,
					["ctrl-s"] = actions.file_vsplit,
				},
			},
			grep = {
				actions = {
					["enter"] = actions.file_edit,
					["ctrl-x"] = actions.file_split,
					["ctrl-s"] = actions.file_vsplit,
				},
			},
			keymap = {  -- this keymap is from the `DEFAULT OPTIONS OF THE DIFFERENT CONFIG SECTIONS BELOW` readme section
				builtin = { ["<c-o>"] = "toggle-preview" },
				fzf = { ["ctrl-q"] = "select-all+accept" },
			},
			keymaps = {  -- this is from the picker sections
				actions = { ["ctrl-x"] = actions.keymap_split, ["ctrl-s"] = actions.keymap_vsplit },
			},
			fzf_opts = { ["--cycle"] = true },
			winopts = { preview = { hidden = true, title = false } },
		})
	end,
}

• there's keymap and keymaps which both sound very confusing :(
• is there a way to minimize this duplication? I thought setting the keymaps for buffers and files would be enough as these are inherited by everyone else but I had to do the same thing for grep

[ibhagwan]

there's keymap and keymaps which both sound very confusing :(

There’s only one keymap table, no “keymaps”, but you’re correct it’s confusing and is on my target list to fix one day, the reason is because there are fzf shell keymaps keymap.fzf and neovim keymaps keymap.builtin which require knowledge how the plugin works behind the scenes.

In any event, from what I see in your config this is irrelevant as you’re trying to configure “actions” which is what happens when you select files, if you wish to combine these for all file-like entries (buffers, files, grep, lsp, etc), define your actions at the global level and they’ll apply to all.

require("fzf-lua").setup({
			"ivy",
			defaults = {
				git_icons = false,
				file_icons = false,
				color_icons = false,
			},
			actions = {
				files = {
					["enter"] = actions.file_edit,
					["ctrl-x"] = actions.file_split,
					["ctrl-s"] = actions.file_vsplit,
				},
			},
…

[halshar]

this works perfect, thanks a ton :)

[halshar]

I'll mark your previous reply as answer but just wanted to ask another question which is not relevant to the discussion but are you planning to add normal mode to the prompt?

I've read other issues where this was discussed as this plugin relies on fzf binary but instead of ctrl+p and ctrl+n to cycle between the results the hjkl in normal mode is so convenient and this was preventing me from switching from telescope :(

[ibhagwan]

I'll mark your previous reply as answer but just wanted to ask another question which is not relevant to the discussion but are you planning to add normal mode to the prompt?

I've read other issues where this was discussed as this plugin relies on fzf binary but instead of ctrl+p and ctrl+n to cycle between the results the hjkl in normal mode is so convenient and this was preventing me from switching from telescope :(

It’s a bit more complicated due to fzf being in the terminal but if all you want is esc+hjkl/g/gg you can achieve that, there’s a discussion about this which shows how to set the binds for it and I believe with newer fzf you can even hide the promp/input.

[halshar]

thank you. And in case anyone sees this I found issue 501 and discussion 1653 which talk about normal mode :)

[ibhagwan]

thank you. And in case anyone sees this I found issue 501 and discussion 1653 which talk about normal mode :)

Correct, #1653 is what I meant, can’t recall the new setting name ATM but we may also be able to get rid of the prompt line in the pseudo normal mode.