file_switch_or_edit and buf_switch_or_edit only switches within the current window/tab?

[dominickng]

Hi, just trying to work out how these options work. Forgive me if I'm misunderstanding them. :)

Let's say I have a.ts and b.ts open in a split in a tab, and c.ts open in a second tab:

Tab 1          Tab 2
a.ts | b.ts    c.ts

Let's say I run fzf-lua files in Tab 1 to find b.ts while focused on a.ts, and run actions.file_switch_or_edit on the result. This behaves as I expect: it changes focus to the split with b.ts.

But if I run fzf-lua files in Tab 1 to find c.ts, I'd expect actions.file_switch_or_edit to focus tab 2 and c.tsthere. Instead, it opensc.ts` in Tab 1 in the currently focused split.

Running fzf-lua tabs makes this behave as I expect (focus the tab/split if the file is already open and visible), but this means I can't open files I don't have open. I'd need to run fzf-lua tabs, find that I don't have a file open, then run fzf-lua files to find the file and open it.

Is there a way to combine these behaviours? Focus the existing open split if a file is already opened, and if it's not opened, open the file? I also want to accomplish this for the tabedit, split, and vsplit options. I've tried the following, but it exhibits the same behaviour as described above:

            ["ctrl-t"] = function(selected, opts)
              if not actions.file_switch(selected, opts) then
                actions.file_tabedit(selected, opts)
              end
            end,

Looking at the implementation, maybe this requires a tabs + files command where tabs are preferred and it falls back to files if not found?

[nenahp]

I know there's a :drop cmd... Maybe that's what you want?

[nenahp]

I test a bit, I think it work well:

          ['enter'] = function(sel, o)
            local entry = require('fzf-lua.path').entry_to_file(sel[1], o, o._uri)
            local fullpath = entry.bufname or entry.uri and entry.uri:match("^%a+://(.*)") or entry.path
            vim.cmd(([[drop %s]]):format(fullpath))
          end,

[ibhagwan]

I test a bit, I think it work well:

          ['enter'] = function(sel, o)
            local entry = require('fzf-lua.path').entry_to_file(sel[1], o, o._uri)
            local fullpath = entry.bufname or entry.uri and entry.uri:match("^%a+://(.*)") or entry.path
            vim.cmd(([[drop %s]]):format(fullpath))
          end,

Interesting, TIL about :drop, Ty @nenahp!

[dominickng]

Brilliant, thanks! TIL about :drop as well as :tab drop to do the same thing but open in new tab rather than current buffer. This was the hint I needed to get the following behaviour for <Enter>, <Ctrl-t>, <Ctrl-s>, and <Ctrl-v>: jump to the buffer if it's open already, or opens the file in the (current buffer|new tab|split|vertical split) if it's not, which is exactly the behaviour I wanted. Config as follows:

      local OutType = {
        OPEN = {},
        NEW_TAB = {}
      }

      -- fzf action which switches to the selected file if it's already open
      -- (using the builtin :drop command), otherwise opens the file. If
      -- OutType is NEWTAB, also passes the :tab option to open in a new tab
      -- rather than current buffer
      local switch_or_drop = function(selected, opts, outtype)
        local entry = require('fzf-lua.path').entry_to_file(selected[1], opts, opts._uri)
        local fullpath = entry.bufname or entry.uri and entry.uri:match("^%a+://(.*)") or entry.path
        local command = (outtype == OutType.NEW_TAB) and "tab drop" or "drop"
        vim.cmd(([[silent %s %s]]):format(command, fullpath))
      end

      -- fzf action which switches to the selected file if it's already open
      -- (using the builtin :sbuffer command), otherwise calls `fallback`.
      local switch_or_fallback = function(selected, opts, fallback)
        local entry = require('fzf-lua.path').entry_to_file(selected[1], opts, opts._uri)
        local fullpath = entry.bufname or entry.uri and entry.uri:match("^%a+://(.*)") or entry.path
        if vim.fn.bufwinid(fullpath) == -1 then
          fallback(selected, opts)
        else
          vim.cmd(([[silent sbuffer %s]]):format(fullpath))
        end
      end

      fzf.setup({
        actions = {
          -- applies to files and buffers commands
          files = {
            true, -- inherit defaults
            ["enter"] = function(selected, opts)
              switch_or_drop(selected, opts, OutType.OPEN);
            end,
            ["ctrl-t"] = function(selected, opts)
              switch_or_drop(selected, opts, OutType.NEW_TAB);
            end,
            ["ctrl-v"] = function(selected, opts)
              switch_or_fallback(selected, opts, fzf.actions.file_vsplit)
            end,
            ["ctrl-s"] = function(selected, opts)
              switch_or_fallback(selected, opts, fzf.actions.file_split)
            end,
          },
        },
       })

[ibhagwan]

Brilliant, thanks! TIL about :drop as well as :tab drop to do the same thing but open in new tab rather than current buffer. This was the hint I needed to get the following behaviour for , , , and : jump to the buffer if it's open already, or opens the file in the (current buffer|new tab|split|vertical split) if it's not. This is exactly the behaviour I wanted. Config as follows:

Lean and clean solution, very nice @dominickng!

[ibhagwan]

Btw, you can drop actions.buffers table altogether as actions.files rules over everything since I unified the actions in 5bd319c, buffer actions are just symlinks:

fzf-lua/lua/fzf-lua/actions.lua

Lines 411 to 419 in 34de854

	M.buf_edit = M.file_edit
	M.buf_split = M.file_split
	M.buf_vsplit = M.file_vsplit
	M.buf_tabedit = M.file_tabedit
	M.buf_sel_to_qf = M.file_sel_to_qf
	M.buf_sel_to_ll = M.file_sel_to_ll
	M.buf_edit_or_qf = M.file_edit_or_qf
	M.buf_switch = M.file_switch
	M.buf_switch_or_edit = M.file_switch_or_edit

[dominickng]

Ah, that's helpful to know. Will drop the buffer table (and edit above to match). Thanks!

[rajaravivarma-r]

@dominickng Thanks for the snippet. It worked as expected for buffer switching, but the cursor is not jumping to the correct line when using FzfLua btags.

Have you faced this or fixed this?

Looks like not just buffers but other actions like blines, btags are also using the same mappings. I tried overriding everything after the setup, but btags keymap also gets updated.

I don't know how to preserver the old keymaps for all other actions like btags, blines etc, while just overriding it for the files actions.

[ibhagwan]

Thank you. To make it more clear, I'm not using the above code for tags. I'm just trying to use it for 'files', by over-writing the 'actions.files', but it over-writes the 'actions.btags' as well, because they are referring to the same function (which is the new function defined by dominickng).

Now that I am over-writing the function, I have to replicate all the logic here too.

Is my understanding right?

Correct, the snippet overrides all files actions, if you don’t wish to override this globally you can instead move the code into actions under any specific picker, for example:

fzf.setup({
  tabs = { actions = { … } }
})

[rajaravivarma-r]

Got it. For tabs, the key bindings work as expected, i.e. opens the tab where the buffer is open, I want the same behaviour when opening files too. So I guess, I'll have to use it as it is for now.

[ibhagwan]

Got it. For tabs, the key bindings work as expected, i.e. opens the tab where the buffer is open, I want the same behaviour when opening files too. So I guess, I'll have to use it as it is for now.

You can do the same for files but if you need to jump to line numbers you’ll need to add more code as the snippet doesn’t contain jumping to lines at all.

[rajaravivarma-r]

Sure. Thanks for your guidance.

[rajaravivarma-r]

For now I've modified the code to call the new version of the function or the existing function based on the FzfLua command being invoked. Warning: I've have not thoroughly checked it.

I'll update the code if I find any issues.

      local original_files_function = fzf_lua.config.defaults.actions.files
      local OutType = { OPEN = "open", NEW_TAB = "new_tab" }
      -- fzf action which switches to the selected file if it's already open
      -- (using the builtin :drop command), otherwise opens the file. If
      -- OutType is NEWTAB, also passes the :tab option to open in a new tab
      -- rather than current buffer
      local switch_or_drop = function(selected, opts, outtype, original_method)
        local info = opts['__INFO']
        local cmd = info.cmd
        local files_opened = cmd == "git_files" or cmd == "files" or cmd == "buffers"


        if files_opened then
          local entry = require("fzf-lua.path").entry_to_file(selected[1], opts, opts._uri)
          local fullpath = entry.bufname or entry.uri and entry.uri:match("^%a+://(.*)") or entry.path
          local command = (outtype == OutType.NEW_TAB) and "tab drop" or "drop"
          vim.cmd(([[silent %s %s]]):format(command, fullpath))
        else
          return original_files_function[original_method](selected, opts)
        end
      end

      -- fzf action which switches to the selected file if it's already open
      -- (using the builtin :sbuffer command), otherwise calls `fallback`.
      local switch_or_fallback = function(selected, opts, fallback)
        local entry = require("fzf-lua.path").entry_to_file(selected[1], opts, opts._uri)
        local fullpath = entry.bufname or entry.uri and entry.uri:match("^%a+://(.*)") or entry.path
        if vim.fn.bufwinid(fullpath) == -1 then
          fallback(selected, opts)
        else
          vim.cmd(([[silent sbuffer %s]]):format(fullpath))
        end
      end

      fzf_lua.setup({
        keymap = {
          builtin = {
            true,
            ["<C-k>"] = "preview-page-up",
            ["<C-j>"] = "preview-page-down",
          },
          fzf = {
            true,
            ["ctrl-k"] = "preview-page-up",
            ["ctrl-j"] = "preview-page-down",
          },
        },
        actions = {
          -- applies to files and buffers commands
          files = {
            true, -- inherit defaults
            ["enter"] = function(selected, opts)
              switch_or_drop(selected, opts, OutType.OPEN, "enter")
            end,
            ["ctrl-t"] = function(selected, opts)
              switch_or_drop(selected, opts, OutType.NEW_TAB, "ctrl-t")
            end,
            ["ctrl-v"] = function(selected, opts)
              switch_or_fallback(selected, opts, fzf_lua.actions.file_vsplit)
            end,
            ["ctrl-s"] = function(selected, opts)
              switch_or_fallback(selected, opts, fzf_lua.actions.file_split)
            end,
          },
        },
      }, true)