Fit window size to content

[savchenko]

Some pickers work best full-screen (e.g. "show me all project files") while others are unlikely to occupy much space (e.g. open buffers).

It is possible to create a pop-up window that fits its content?

Somewhat related to #1934

[ibhagwan]

Haven't tested but this would be my approach:

• Hook the load event (similar to what we do in testing) - the event will only trigger once all (async) resulsts are fully loaded (fzf loading indicator stops spinning)
• Get the number of lines either from the neovim window or number of results from fzf using the environment variable $FZF_TOTAL_COUNT (see v0.46 changelog)
• Get the window object from FzfLua.utils.fzf_winobj(), set the layout (height) and call win:redraw() (see example how we toggle fullscreen)

[savchenko]

Would it make sense to make this default?

For example, :FzfLua tabs is highly unlikely to ever return enough of content to occupy the full screen.

[ibhagwan]

Would it make sense to make this default?

For example, :FzfLua tabs is highly unlikely to ever return enough of content to occupy the full screen.

Too much hassle for what is guaranteed to end up being a personal preference with a “why does my window height change dynamically” issue, although to customize tabs height you can probably do it yourself very easily as the content height is predictable, for example see this issue where we move the cursor upon open to the right tab, you can do the same but return winopts.height instead (which also accepts line num instead of 0.x percent):
#1870 (comment)

[ibhagwan]

You can also borrow some logic from the wiki on how to dynamically size vim.ui.select
https://github.com/ibhagwan/fzf-lua/wiki#automatic-sizing-of-heightwidth-of-vimuiselect

[nenahp]

require('fzf-lua').tabs({
  actions = {
    result = {
      fn = function(s)
        local fzf_match_cnt = tonumber(unpack(s))
        local w = require('fzf-lua.utils').fzf_winobj()
        -- w._o.winopts.width = 30
        w._o.winopts.height = fzf_match_cnt + 10
        w:redraw()
      end,
      exec_silent = true,
      field_index = '$FZF_MATCH_COUNT',
    },
})

You can also resize on "change" but a bit more flick.

[savchenko]

Thanks @ibhagwan and @nenahp . Here is the full config with autofocus and automatic width / height:

return {
    "https://github.com/ibhagwan/fzf-lua",
    version = "*",
    config = function()
        local win_opts = function()
            local bufs_fn_len = {}
            local max_len = 0
            for _, buf_nr in ipairs(vim.api.nvim_list_bufs()) do
                if vim.api.nvim_buf_is_valid(buf_nr) then
                    local buf_listed = vim.api.nvim_get_option_value('buflisted', { buf = buf_nr })
                    local buf_nm = vim.api.nvim_buf_get_name(buf_nr)
                    buf_nm = vim.fn.expand(buf_nm)
                    buf_nm = vim.fn.fnamemodify(buf_nm, ":.")
                    if buf_listed then
                        if buf_nm ~= '' then
                            buf_len = string.len(buf_nm)
                            table.insert(bufs_fn_len, buf_len)
                        end
                    end
                end
            end
            for _, len in ipairs(bufs_fn_len) do
                max_len = math.max(max_len, len)
            end
            return {
                height = #bufs_fn_len + 6,
                width = max_len + 6,
            }
        end
        require('fzf-lua').setup({
            tabs = {
                keymap = function() -- autofocus current tab
                    local curtab = vim.fn.tabpagenr()
                    local pos = 1
                    for i, t in ipairs(vim.api.nvim_list_tabpages()) do
                        if i < curtab then pos = pos + 1 + #vim.api.nvim_tabpage_list_wins(t) end
                    end
                    return { fzf = { load = string.format("transform:echo 'pos(%d)'", pos) } }
                end,
                actions = {
                    result = {
                        fn = function(s)
                            local fzf_match_cnt = tonumber(unpack(s))
                            local w = require('fzf-lua.utils').fzf_winobj()
                            local opts = win_opts()
                            w._o.winopts.width = opts.width + 20
                            w._o.winopts.height = fzf_match_cnt + 3
                            w:redraw()
                        end,
                        exec_silent = true,
                        field_index = '$FZF_MATCH_COUNT',
                    },
                }
            },
        })
    end
}

Resulting window, correctly padded:

[savchenko]

P.S. "Select current item by default" might be something worth adding as standard. Would work nicely for tabs, files, etc.

[ibhagwan]

Thanks @ibhagwan and @nenahp . Here is the full config with autofocus and automatic width / height:

Ty @savchenko and @phanen for the clean implementation, sometimes I get scared seeing the level of customization by users :)

[ibhagwan]

P.S. "Select current item by default" might be something worth adding as standard. Would work nicely for tabs, files, etc.

For tabs perhaps, for files I’m not sure as the current file might not necessarily be in the opening page of fzf, I’m not sure how we’ll be able to find it then.

[savchenko]

addb648 solves the problem.

I have updated Wiki with https://github.com/ibhagwan/fzf-lua/wiki#prevent-window-flashing-during-size-change

[ibhagwan]

addb648 solves the problem.

I have updated Wiki with https://github.com/ibhagwan/fzf-lua/wiki#prevent-window-flashing-during-size-change

Ty @savchenko!