Scrolling the previewer in the buffers provider

[ohri-anurag]

Hi,

I'm trying to configure the scrolling keys to the buffers provider using the following setup:

  keymap = {
    builtin = {
      ["<C-d>"] = "preview-page-down",
      ["<C-u>"] = "preview-page-up",
    },
  },
  buffers = {
    actions = {
      ["ctrl-d"] = false,
    },
  },

If I don't set the actions setting, then Ctrl-d closes the currently highlighted buffer. If I do set it to false, then Ctrl-d doesn't do anything. Is there anything I can do to make this work?

This plugin is awesome btw! Thanks!

[ibhagwan]

Are you using bat previewer? Bat is a “native” previewer requiring to setup similar binds under keymap.fzf.

[ohri-anurag]

This is all the fzf-lua related config that I have:

Plug("ibhagwan/fzf-lua", { branch = "main" })

local fzf = require("fzf-lua")
local actions = require("fzf-lua").actions
fzf.setup({
  "telescope",
  grep = {
    rg_glob = true,
  },
  fzf_opts = { ["--cycle"] = "" },
  keymap = {
    builtin = {
      ["<C-d>"] = "preview-page-down",
      ["<C-u>"] = "preview-page-up",
    },
    fzf = {
      ["ctrl-d"] = "preview-page-down",
      ["ctrl-u"] = "preview-page-up",
    },
  },
  buffers = {
    actions = {
      ["ctrl-d"] = false,
    },
  },
})
vim.keymap.set("n", "<leader>fg", fzf.grep_cword, {})
vim.keymap.set("n", "<leader>lg", fzf.live_grep, {})
vim.keymap.set("n", "<leader>ft", fzf.tags_grep_cword, {})
vim.keymap.set("n", "<leader>lt", fzf.tags, {})
vim.keymap.set("n", "<leader>ff", fzf.files, {})
vim.keymap.set("n", "<leader>fb", fzf.buffers, {})

I don't think that I'm using the bat previewer. Even after setting it in keymap.fzf, the keybinding for Ctrl-d doesn't work.

Is there a way that I can disable buffer closing in the buffer provider? I don't close buffers at all, so Ctrl-d for closing buffers is not useful for me.

[ohri-anurag]

[ibhagwan]

Maybe it’s a bug, I only see the ctrl-u mapped, I’ll test your config.

[ibhagwan]

Strange, your exact setup on my machine works as expected (see below), search your config for <C-d>` maybe you have something that unmaps it, otherwise my guess would be another plugin conflict?

What you can do to try to see if your config is the issue is run fzf-lua with mini.sh:

sh -c "$(curl -s https://raw.githubusercontent.com/ibhagwan/fzf-lua/main/scripts/mini.sh)"

This is the config I saved into test.lua and ran :so %:

local fzf = require("fzf-lua")
fzf.setup({
  "telescope",
  grep = {
    rg_glob = true,
  },
  fzf_opts = { ["--cycle"] = "" },
  keymap = {
    builtin = {
      ["<C-d>"] = "preview-page-down",
      ["<C-u>"] = "preview-page-up",
    },
    fzf = {
      ["ctrl-d"] = "preview-page-down",
      ["ctrl-u"] = "preview-page-up",
    },
  },
  buffers = {
    actions = {
      ["ctrl-d"] = false,
    },
  },
})

Save your config to a lua file, open it (after starting with mini.sh) and run it with :so %, then test if you see the ctrl-d bind in the F1 help, just did that as well and I see it (notice the default colorscheme):

[ohri-anurag]

The code for the telescope profile gave me some hints at this, I finally got it working:

local fzf = require("fzf-lua")
local actions = require("fzf-lua").actions
fzf.setup({
  "telescope",
  grep = {
    rg_glob = true,
  },
  fzf_opts = { ["--cycle"] = "" },
  buffers = {
    actions = {
      ["ctrl-d"] = false,
    },
    keymap = {
      builtin = {
        ["<C-d>"] = "preview-page-down",
        ["<C-u>"] = "preview-page-up",
      },
    },
  },
})
vim.keymap.set("n", "<leader>fg", fzf.grep_cword, {})
vim.keymap.set("n", "<leader>lg", fzf.live_grep, {})
vim.keymap.set("n", "<leader>ft", fzf.tags_grep_cword, {})
vim.keymap.set("n", "<leader>lt", fzf.tags, {})
vim.keymap.set("n", "<leader>ff", fzf.files, {})
vim.keymap.set("n", "<leader>fb", fzf.buffers, {})

For all other providers, this was working fine. But just for the buffer provider, the telescope profile sets the binding <C-d> to false:

fzf-lua/lua/fzf-lua/profiles/telescope.lua

Line 79 in d8144cd

keymap = { builtin = { ["<C-d>"] = false } },

[ibhagwan]

For all other providers, this was working fine. But just for the buffer provider

You’re right, I didn’t realize the issue was only for buffers and Telescope uses ctrl-d to buf del, good find.

[ibhagwan]

Btw rg_glob = true isn’t required anymore, it’s the default:

fzf-lua/lua/fzf-lua/defaults.lua

Line 507 in d8144cd

rg_glob = 1, -- do not display warning if using `grep`

[ibhagwan]

Another important note, you’re overriding the key maps and not inheriting the defaults, if that’s your intention that’s fine, if you wish to inherit the other defaults use:

    keymap = {
      builtin = {
        true, -- < this 
        ["<C-d>"] = "preview-page-down",
        ["<C-u>"] = "preview-page-up",
      },

[ohri-anurag]

Adding true as the first argument to builtin breaks the buffers provider. For now I've removed it.