add phpcs

Author: dannyvankooten

.editorconfig

@@ -11,7 +11,8 @@ charset = utf-8
 end_of_line = lf
 insert_final_newline = true
 trim_trailing_whitespace = true
-indent_style = tab
+indent_style = space
+indent_size = 4
 
 [*.{yaml,yml}]
 indent_style = space

.github/workflows/check-php-syntax.yml

@@ -21,3 +21,8 @@ jobs:
 
       # Lint every PHP source file using PHP interpreter
       - run: composer run check-syntax
+
+      - run: composer install --no-progress
+        if: ${{ matrix.php-versions }} == '8.3'
+      - run: ./vendor/bin/phpcs -ns
+        if: ${{ matrix.php-versions }} == '8.3'

composer.json

@@ -17,5 +17,8 @@
 	},
 	"scripts": {
     	"check-syntax": "find . -name '*.php' -not -path './vendor/*' -not -path './node_modules/*' -print0 | xargs -0 -n1 php -l"
+	},
+	"require-dev": {
+		"squizlabs/php_codesniffer": "^3.11"
 	}
 }

composer.lock

@@ -28,50 +28,48 @@
 along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
 
-defined( 'ABSPATH' ) or exit;
+defined('ABSPATH') or exit;
 
-add_action( 'plugins_loaded', function() {
-	// check for MailChimp for WordPress (version 3.0 or higher)
-	if ( !defined( 'MC4WP_VERSION' ) || version_compare( MC4WP_VERSION, '3.0', '<' ) ) {
-		// Show notice to user
-		add_action( 'admin_notices',  function() {
+add_action('plugins_loaded', function () {
+    // check for MailChimp for WordPress (version 3.0 or higher)
+    if (!defined('MC4WP_VERSION') || version_compare(MC4WP_VERSION, '3.0', '<')) {
+        // Show notice to user
+        add_action('admin_notices', function () {
 
-			// only show to user with caps
-			if( ! current_user_can( 'install_plugins' ) ) {
-				return;
-			}
+            // only show to user with caps
+            if (! current_user_can('install_plugins')) {
+                return;
+            }
 
-			add_thickbox();
-			$url = network_admin_url( 'plugin-install.php?tab=plugin-information&plugin=mailchimp-for-wp&TB_iframe=true&width=600&height=550' );
-			?>
-			<div class="notice notice-warning is-dismissible">
-				<p><?php printf( __( 'Please install or update <a href="%s" class="thickbox">%s</a> in order to use %s.', 'mailchimp-top-bar' ), $url, '<strong>MailChimp for WordPress</strong> (version 3.0 or higher)', 'MailChimp Top Bar' ); ?></p>
-			</div>
-		<?php
-		});
-		return;
-	}
+            add_thickbox();
+            $url = network_admin_url('plugin-install.php?tab=plugin-information&plugin=mailchimp-for-wp&TB_iframe=true&width=600&height=550');
+            ?>
+            <div class="notice notice-warning is-dismissible">
+                <p><?php printf(__('Please install or update <a href="%s" class="thickbox">%s</a> in order to use %s.', 'mailchimp-top-bar'), $url, '<strong>MailChimp for WordPress</strong> (version 3.0 or higher)', 'MailChimp Top Bar'); ?></p>
+            </div>
+            <?php
+        });
+        return;
+    }
 
 
-	define('MAILCHIMP_TOP_BAR_FILE', __FILE__);
-	define('MAILCHIMP_TOP_BAR_DIR', __DIR__);
-	define('MAILCHIMP_TOP_BAR_VERSION', '1.6.2');
+    define('MAILCHIMP_TOP_BAR_FILE', __FILE__);
+    define('MAILCHIMP_TOP_BAR_DIR', __DIR__);
+    define('MAILCHIMP_TOP_BAR_VERSION', '1.6.2');
 
-	require __DIR__ . '/src/functions.php';
+    require __DIR__ . '/src/functions.php';
 
-	if( ! is_admin() ) {
-		// frontend code
-		require __DIR__ . '/src/Bar.php';
-		$bar = new MailChimp\TopBar\Bar();
-		$bar->add_hooks();
-	} elseif( defined( 'DOING_AJAX' ) && DOING_AJAX ) {
-		// ajax code
-
-	} else {
-		// admin code
-		require __DIR__ . '/src/Admin.php';
-		$admin = new Mailchimp\TopBar\Admin();
-		$admin->add_hooks();
-	}
-
-}, 30 );
+    if (! is_admin()) {
+        // frontend code
+        require __DIR__ . '/src/Bar.php';
+        $bar = new MailChimp\TopBar\Bar();
+        $bar->add_hooks();
+    } elseif (defined('DOING_AJAX') && DOING_AJAX) {
+        // ajax code
+    } else {
+        // admin code
+        require __DIR__ . '/src/Admin.php';
+        $admin = new Mailchimp\TopBar\Admin();
+        $admin->add_hooks();
+    }
+}, 30);

mailchimp-top-bar.php

@@ -0,0 +1,13 @@
+<?xml version="1.0"?>
+<ruleset name="rules">
+	<description>rules</description>
+	<arg name="colors"/>
+	<file>src/</file>
+	<file>mailchimp-top-bar.php</file>
+	<exclude-pattern>*\.(html|css|js)</exclude-pattern>
+	<rule ref="Generic.Arrays.DisallowLongArraySyntax.Found"/>
+	<rule ref="PSR12">
+		<exclude name="Squiz.Classes.ValidClassName.NotCamelCaps" />
+		<exclude name="PSR1.Methods.CamelCapsMethodName.NotCamelCaps" />
+	</rule>
+</ruleset>