use is_file over file_exists

Author: dannyvankooten

src/class-endpoint-installer.php

@@ -90,7 +90,7 @@ public function install(): bool
         // TODO: Verify contents? Or trust 200 OK response?
 
         /* Attempt to put the file into place if it does not exist already */
-        if (! file_exists($file_name)) {
+        if (! is_file($file_name)) {
             $success = file_put_contents($file_name, $this->get_file_contents());
             if (false === $success) {
                 return false;

src/collect-functions.php

@@ -96,12 +96,7 @@ function collect_request()
         return;
     }
 
-    if (isset($_GET['e'])) {
-        $data = extract_event_data($_GET);
-    } else {
-        $data = extract_pageview_data($_GET);
-    }
-
+    $data = isset($_GET['e']) ? extract_event_data($_GET) : extract_pageview_data($_GET);
     if (!empty($data)) {
         $success = isset($_GET['test']) ? test_collect_in_file() : collect_in_file($data);
 

src/functions.php

@@ -146,7 +146,7 @@ function using_custom_endpoint(): bool
     }
 
     /** @see Endpoint_Installer::get_file_name() */
-    return \file_exists(\rtrim(ABSPATH, '/') . '/koko-analytics-collect.php') && (bool) get_option('koko_analytics_use_custom_endpoint', false);
+    return \is_file(\rtrim(ABSPATH, '/') . '/koko-analytics-collect.php') && (bool) get_option('koko_analytics_use_custom_endpoint', false);
 }
 
 function create_local_datetime(string $timestr): \DateTimeImmutable