notifier: Ignore errors and move on

Better than crashing the entire flow

Author: iamkroot

trakt_scrobbler/__init__.py

@@ -6,24 +6,29 @@
 import confuse
 import yaml
 
+APP_NAME = 'Trakt Scrobbler'
 # For reasons beyond my understanding, we cannot instantiate
 # DesktopNotifier _after_ we have imported pythoncom on Windows.
 # Trying to do so gives error "The application called an interface that was marshalled for a different thread"
 # 
 # Possibly a conflict between win32 (pythoncom) and winrt (notifier) APIs.
 # 
 # So workaround is to instantiate the notifier _before_ any other import happens
-APP_NAME = 'Trakt Scrobbler'
-from desktop_notifier.main import DesktopNotifier
-
-notifier = DesktopNotifier(APP_NAME)
-if sys.platform == 'win32':
-    # this is another workaround for windows.
-    # See https://github.com/samschott/desktop-notifier/issues/95
-    notifier._did_request_authorisation = True
-# else:
-#     # can be initialized later
-#     notifier = None
+try:
+    from desktop_notifier.main import DesktopNotifier
+
+    notifier = DesktopNotifier(APP_NAME)
+except Exception as e:
+    # FIXME: haven't even initialized logging yet, where to log??
+    print("Error setting up notifier!", e, file=sys.stderr)
+    print("\nReport this issue to github.", file=sys.stderr)
+    notifier = None
+else:
+    if sys.platform == 'win32':
+        # this is another workaround for windows.
+        # See https://github.com/samschott/desktop-notifier/issues/95
+        notifier._did_request_authorisation = True
+
 
 from trakt_scrobbler.log_config import LOGGING_CONF
 from trakt_scrobbler.__version__ import __version__  # noqa

trakt_scrobbler/notifier.py

@@ -66,7 +66,7 @@ def flatten_categories(categories: dict, parents=[]):
 merge_categories(categories, user_notif_categories)
 enabled_categories = set(flatten_categories(categories))
 
-if enabled_categories:
+if notifier is not None and enabled_categories:
     logger.debug(
         "Notifications enabled for categories: "
         f"{', '.join(sorted(enabled_categories))}"
@@ -92,10 +92,13 @@ def notify_loop():
 notif_action_interface = config['general']['notif_actions']['primary_interface'].get(
     confuse.Choice(['button', 'click'], default='button')
 )
-logger.debug(
-    "Notif actions enabled for categories: "
-    f"{', '.join(sorted(enabled_notif_action_categories))}"
-)
+if notifier is not None:
+    logger.debug(
+        "Notif actions enabled for categories: "
+        f"{', '.join(sorted(enabled_notif_action_categories))}"
+    )
+else:
+    logger.warning("Notifier is not initialized!")
 
 
 def notify(
@@ -108,6 +111,8 @@ def notify(
 ):
     if stdout:
         print(body)
+    if notifier is None:
+        return
     if category not in enabled_categories:
         return
     if actions and category in enabled_notif_action_categories:
@@ -119,9 +124,13 @@ def notify(
     else:
         on_clicked = None
         actions = ()
-    notif_task = notifier.send(
-        title, body, icon="", on_clicked=on_clicked, buttons=actions
-    )
+    try:
+        notif_task = notifier.send(
+            title, body, icon="", on_clicked=on_clicked, buttons=actions
+        )
+    except Exception:
+        logger.error("Error when creating notification", exc_info=True)
+        return
     fut = asyncio.run_coroutine_threadsafe(notif_task, notif_loop)
     try:
         # wait for the notification to be _sent_