Skip to content

Commit 1adbc25

Browse files
committed
don't store the log level locally
Use `log::max_level()` instead. This enables us to have a static logger instance and no-longer require `std` with `log`. I'm not sure if there are any tangible benefits for this though.
1 parent e10e611 commit 1adbc25

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ documentation = "https://docs.rs/console_log"
1313

1414
[dependencies.log]
1515
version = "0.4"
16-
features = ["std"]
1716

1817
[dependencies.web-sys]
1918
version = "0.3"

src/lib.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,14 +77,13 @@
7777
use log::{Log, Level, Record, Metadata, SetLoggerError};
7878
use web_sys::console;
7979

80+
static LOGGER: WebConsoleLogger = WebConsoleLogger {};
8081

81-
struct WebConsoleLogger {
82-
level: Level,
83-
}
82+
struct WebConsoleLogger {}
8483

8584
impl Log for WebConsoleLogger {
8685
fn enabled(&self, metadata: &Metadata) -> bool {
87-
metadata.level() <= self.level
86+
metadata.level() <= log::max_level()
8887
}
8988

9089
fn log(&self, record: &Record) {
@@ -118,8 +117,7 @@ impl Log for WebConsoleLogger {
118117
/// }
119118
/// ```
120119
pub fn init_with_level(level: Level) -> Result<(), SetLoggerError> {
121-
let logger = WebConsoleLogger { level };
122-
log::set_boxed_logger(Box::new(logger))?;
120+
log::set_logger(&LOGGER)?;
123121
log::set_max_level(level.to_level_filter());
124122
Ok(())
125123
}

0 commit comments

Comments
 (0)