Skip to content

Commit f23459e

Browse files
author
volker
committed
remove the not used interface IVariableNode and the stub implementations
of replaceVariables()
1 parent 3bd1c93 commit f23459e

15 files changed

+18
-162
lines changed

src/main/java/com/inet/sass/tree/BlockNode.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import com.inet.sass.selector.Selector;
2828
import com.inet.sass.visitor.BlockNodeHandler;
2929

30-
public class BlockNode extends Node implements IVariableNode {
30+
public class BlockNode extends Node {
3131

3232
private List<Selector> selectorList;
3333

@@ -90,9 +90,7 @@ public String toString() {
9090
return "BlockNode [" + buildString(true, TO_STRING_STRATEGY) + "]";
9191
}
9292

93-
@Override
94-
public void replaceVariables(ScssContext context) {
95-
93+
private void replaceVariables(ScssContext context) {
9694
if (selectorList == null || selectorList.isEmpty()) {
9795
return;
9896
}

src/main/java/com/inet/sass/tree/DefNode.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import com.inet.sass.Definition;
2020
import com.inet.sass.Scope;
21-
import com.inet.sass.ScssContext;
2221
import com.inet.sass.parser.ActualArgumentList;
2322
import com.inet.sass.parser.FormalArgumentList;
2423

@@ -29,8 +28,7 @@
2928
* @author Vaadin
3029
*
3130
*/
32-
public abstract class DefNode extends Node implements Definition,
33-
IVariableNode, NodeWithUrlContent {
31+
public abstract class DefNode extends Node implements Definition, NodeWithUrlContent {
3432
private String name;
3533
private FormalArgumentList arglist;
3634
private Scope definitionScope;
@@ -60,10 +58,6 @@ public boolean hasVariableArguments() {
6058
return arglist.hasVariableArguments();
6159
}
6260

63-
@Override
64-
public void replaceVariables(ScssContext context) {
65-
}
66-
6761
public void replacePossibleArguments(ActualArgumentList actualArgumentList) {
6862
// TODO instead of modifying def, return a VariableArgumentList?
6963
arglist = arglist.replaceFormalArguments(actualArgumentList, true);

src/main/java/com/inet/sass/tree/ExtendNode.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import com.inet.sass.selector.Selector;
2828
import com.inet.sass.visitor.ExtendNodeHandler;
2929

30-
public class ExtendNode extends Node implements IVariableNode {
30+
public class ExtendNode extends Node {
3131

3232
private List<Selector> list;
3333
private boolean optional;
@@ -48,11 +48,6 @@ public List<Selector> getList() {
4848
return list;
4949
}
5050

51-
@Override
52-
public void replaceVariables(ScssContext context) {
53-
54-
}
55-
5651
@Override
5752
public String toString() {
5853
return "Extend node [" + getListAsString() + "]";

src/main/java/com/inet/sass/tree/IVariableNode.java

Lines changed: 0 additions & 25 deletions
This file was deleted.

src/main/java/com/inet/sass/tree/KeyframesNode.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import com.inet.sass.ScssContext;
2424
import com.inet.sass.parser.StringInterpolationSequence;
2525

26-
public class KeyframesNode extends Node implements IVariableNode {
26+
public class KeyframesNode extends Node {
2727
private String keyframeName;
2828
private StringInterpolationSequence animationName;
2929

@@ -51,16 +51,11 @@ public String toString() {
5151

5252
@Override
5353
public Collection<Node> traverse(ScssContext context) {
54-
replaceVariables(context);
54+
animationName = animationName.replaceVariables(context);
5555
traverseChildren(context);
5656
return Collections.singleton((Node) this);
5757
}
5858

59-
@Override
60-
public void replaceVariables(ScssContext context) {
61-
animationName = animationName.replaceVariables(context);
62-
}
63-
6459
private String buildString(BuildStringStrategy strategy) {
6560
StringBuilder string = new StringBuilder();
6661
string.append(keyframeName).append(" ").append(animationName)

src/main/java/com/inet/sass/tree/MessageNode.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import com.inet.sass.handler.SCSSErrorHandler;
2424
import com.inet.sass.parser.SassListItem;
2525

26-
public class MessageNode extends Node implements IVariableNode {
26+
public class MessageNode extends Node {
2727

2828
public static enum MessageLevel {
2929
debug, warn, error;
@@ -37,11 +37,6 @@ public MessageNode( SassListItem message, MessageLevel level ) {
3737
this.level = level;
3838
}
3939

40-
@Override
41-
public void replaceVariables( ScssContext context ) {
42-
message = message.evaluateFunctionsAndExpressions( context, true );
43-
}
44-
4540
@Override
4641
public String printState() {
4742
return "";
@@ -55,7 +50,7 @@ public String toString() {
5550
@Override
5651
public Collection<Node> traverse( ScssContext context ) {
5752
SCSSErrorHandler handler = SCSSErrorHandler.get();
58-
replaceVariables( context );
53+
message = message.evaluateFunctionsAndExpressions( context, true );
5954
String msg = message.evaluateFunctionsAndExpressions( context, true ).unquotedString();
6055
switch( level ) {
6156
case debug:

src/main/java/com/inet/sass/tree/MixinNode.java

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@
3535
*
3636
* @author Vaadin
3737
*/
38-
public class MixinNode extends Node implements IVariableNode,
39-
NodeWithUrlContent {
38+
public class MixinNode extends Node implements NodeWithUrlContent {
4039

4140
// these are the actual parameter values, not whether the definition node
4241
// uses varargs
@@ -67,15 +66,6 @@ public String getName() {
6766
return name;
6867
}
6968

70-
/**
71-
* Replace variable references with their values in the argument list and
72-
* name.
73-
*/
74-
@Override
75-
public void replaceVariables(ScssContext context) {
76-
arglist = arglist.evaluateFunctionsAndExpressions(context, true);
77-
}
78-
7969
@Override
8070
public String printState() {
8171
return "name: " + getName() + " args: " + getArglist();
@@ -89,7 +79,7 @@ public String toString() {
8979
@Override
9080
public Collection<Node> traverse( ScssContext context ) {
9181
try {
92-
replaceVariables( context );
82+
arglist = arglist.evaluateFunctionsAndExpressions(context, true);
9383
expandVariableArguments();
9484
// inner scope is managed by MixinNodeHandler
9585
return MixinNodeHandler.traverse( context, this );

src/main/java/com/inet/sass/tree/NestPropertiesNode.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import com.inet.sass.ScssContext;
2525
import com.inet.sass.parser.StringInterpolationSequence;
2626

27-
public class NestPropertiesNode extends Node implements IVariableNode {
27+
public class NestPropertiesNode extends Node {
2828

2929
private StringInterpolationSequence name;
3030

@@ -69,15 +69,10 @@ public RuleNode createNewRuleNodeFromChild(RuleNode child) {
6969
return newRuleNode;
7070
}
7171

72-
@Override
73-
public void replaceVariables(ScssContext context) {
74-
name = name.replaceVariables(context);
75-
}
76-
7772
@Override
7873
public Collection<Node> traverse(ScssContext context) {
7974
traverseChildren(context);
80-
replaceVariables(context);
75+
name = name.replaceVariables(context);
8176
return unNesting();
8277
}
8378

src/main/java/com/inet/sass/tree/ReturnNode.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@
2222
import com.inet.sass.ScssContext;
2323
import com.inet.sass.parser.SassListItem;
2424

25-
public class ReturnNode extends Node implements IVariableNode,
26-
NodeWithUrlContent {
25+
public class ReturnNode extends Node implements NodeWithUrlContent {
2726

2827
private SassListItem expr;
2928

@@ -36,10 +35,6 @@ private ReturnNode(ReturnNode nodeToCopy) {
3635
expr = nodeToCopy.expr;
3736
}
3837

39-
@Override
40-
public void replaceVariables(ScssContext context) {
41-
}
42-
4338
@Override
4439
public Collection<Node> traverse(ScssContext context) {
4540
// need to replace variables here to make sure all vars are in scope

src/main/java/com/inet/sass/tree/RuleNode.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import com.inet.sass.parser.SassListItem;
2525
import com.inet.sass.parser.StringInterpolationSequence;
2626

27-
public class RuleNode extends Node implements IVariableNode, NodeWithUrlContent {
27+
public class RuleNode extends Node implements NodeWithUrlContent {
2828

2929
StringInterpolationSequence variable;
3030
SassListItem value;
@@ -84,10 +84,6 @@ public void setComment(String comment) {
8484
this.comment = comment;
8585
}
8686

87-
@Override
88-
public void replaceVariables(ScssContext context) {
89-
}
90-
9187
@Override
9288
public Collection<Node> traverse(ScssContext context) {
9389
/*

0 commit comments

Comments
 (0)