Replies: 1 comment 2 replies
-
First incompatibility: No E.g. encountered in auto begin = PointAccessIterator<Decompressor, DictionaryIteratorType, PosListIteratorType>{
_dictionary->cbegin(), _segment.null_value_id(), vector.create_decompressor(), position_filter->cbegin(),
position_filter->cbegin()}; auto begin = PointAccessIterator<Decompressor, DictionaryIteratorType, PosListIteratorType>{
_dictionary_span->begin(), _segment.null_value_id(), vector.create_decompressor(), position_filter->cbegin(),position_filter->cbegin()}; Do we know if using begin() instead of cbegin() / normal iterator instead of const iterator will have any impact on us? (I know that std::span doesn't offer cbegin, just asking if someone already thought about it - but would be fine with running with it for now. I think there was some discussion about offering a cbegin/cend interface for std::spans but would have to research what's the current state.) |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
This thread is collecting known incompatibilities/limitations for our codebase when switching from vector-based to span-based access to data.
Std::span offers a far more limited interface than std::vector (but a strict subset), so we will probably be unable to adapt everything identically. This thread documents incompatibilities and invites discussion of the relevance/impact of changes.
Beta Was this translation helpful? Give feedback.
All reactions