Drag source icon not positioned correctly per Wayland specification

[pdf]

Hyprland does not implement the wayland spec per:

https://wayland.app/protocols/wayland#wl_data_device:request:start_drag

Specifically:

Initially, the top-left corner of the icon surface is placed at the cursor hotspot, but subsequent wl_surface.offset requests can move the relative position. Attach requests must be confirmed with wl_surface.commit as usual. The icon surface is given the role of a drag-and-drop icon. If the icon surface already has another role, it raises a protocol error.

Please see previous discussions here:

#9564

And what appears to be a complete PR here:

#9652

It's not clear to me precisely which elements of the PR were rejected.

[ghost]

It's not clear to me precisely which elements of the PR were rejected.

none, i just closed it, the maintainer doesn't want to follow the spec specifically for dnd ig

[vaxerski]

The MR touched code unrelated to the icon positioning. I said I would accept it if it was atomic (so it didn't touch what was unrelated to the icon's position)

[ghost]

it's not unrelated, the specification linked was this:

https://wayland.app/protocols/wayland#wl_data_device:request:start_drag

which specifically states:

The source argument is the data source that provides the data for the eventual data transfer. If source is NULL, enter, leave and motion events are sent only to the client that initiated the drag and the client is expected to handle the data passing internally. If source is destroyed, the drag-and-drop session will be cancelled.
The origin surface is the surface where the drag originates and the client must have an active implicit grab that matches the serial.
The icon surface is an optional (can be NULL) surface that provides an icon to be moved around with the cursor. Initially, the top-left corner of the icon surface is placed at the cursor hotspot, but subsequent wl_surface.offset requests can move the relative position. Attach requests must be confirmed with wl_surface.commit as usual. The icon surface is given the role of a drag-and-drop icon. If the icon surface already has another role, it raises a protocol error.
The input region is ignored for wl_surfaces with the role of a drag-and-drop icon.
The given source may not be used in any further set_selection or start_drag requests. Attempting to reuse a previously-used source may send a used_source error.

all changes in the mr were related to this, including internal drag, cursor hotspot icon positioning, etc

[vaxerski]

Promoted #9892