Tearing breaks when moving hardware cursor

[phonetic112]

System info and config

info.txt

Regression

No

Describe the bug

#9830

When tearing and using hardware cursors, moving the cursor causes the framerate of the application to drop (in my case, to exactly 48 fps). Happens regardless of also using direct scanout

Additionally, when only using direct scanout without tearing, the framerate also drops, in my case to 72 fps (half of my monitor refresh rate)

Reproduction steps

1. Enable hardware cursors and tearing
2. Tear any window (that lets your cursor remain visible)
3. Move the cursor

[vaxerski]

Additionally, when only using direct scanout without tearing, the framerate also drops

sounds like nvidia?

Have you tried disabling hw cursors?

[phonetic112]

seems like 2 doesn't even work, it still uses hw cursors when tearing

[vaxerski]

how do you know that?

[phonetic112]

because it still causes the fps drops as with no_hardware_cursors = 0

[ryincler]

This is a regression. I bisected this recently.

First bad commit is 1309b59

Conditions this happens for me:
general:allow_tearing = true and must be actively tearing the current window
cursor:no_hardware_cursors = 0 (must be using hardware cursors)
cursor:use_cpu_buffer = 1 MUST BE ENABLED FOR THIS TO HAPPEN (does not happen with =0)
nvidia system

My gut feeling tells me that this might be an nvidia-only problem, and that maybe something extra needs to be done to respect use_cpu_buffer when calling CMonitor::onCursorMovedOnMonitor(), but i have no proof to base this on.

[vaxerski]

if you patch out the tearingState.frameScheduledWhileBusy = true; does it fix itself?