Screenshots and screenshare showing black screen after #11294

[doomperfect]

As title, discussion in #11294 - grim screenshots and Vesktop screenshare are showing black screen. Hyprpicker is also broken, always shows near-black or black colours (hyprwm/hyprpicker#134)

Reverting commit #9607e3b fixes issue, also this patch fixes it:

diff --git a/src/protocols/Screencopy.cpp b/src/protocols/Screencopy.cpp
index ffaca4d2..98522a94 100644
--- a/src/protocols/Screencopy.cpp
+++ b/src/protocols/Screencopy.cpp
@@ -205,8 +205,8 @@ void CScreencopyFrame::renderMon() {
     g_pHyprOpenGL->setRenderModifEnabled(false);
     g_pHyprOpenGL->renderTexture(TEXTURE, monbox,
                                  {
-                                     .cmBackToSRGB       = !IS_CM_AWARE,
-                                     .cmBackToSRGBSource = !IS_CM_AWARE ? m_monitor.lock() : nullptr,
+                                    //  .cmBackToSRGB       = !IS_CM_AWARE,
+                                    //  .cmBackToSRGBSource = !IS_CM_AWARE ? m_monitor.lock() : nullptr,
                                  });
     g_pHyprOpenGL->setRenderModifEnabled(true);
     g_pHyprOpenGL->popMonitorTransformEnabled();

hyprctl_sysinfo.txt

cc: @vaxerski

[doomperfect]

The screenshot in hyprwm/hyprpicker#134 with the partial greens is interesting, cuz I also noticed that hyprpicker showed colours in the lower nibble of the g byte (like #000A00) whenever it showed anything other than #000000. Maybe its some kind of math issue in some scenarios (not sure why it would only happen on some setups tho?)

[UjinT34]

HL config needed. Might be some issues with specific monitor settings.

[doomperfect]

Yea soz forgot, added conf to main post now

[Zebra2711]

When I use obs to record, the screen goes black when I select full-screen or a region, but it works fine with window capture. It's not completely black, it's like a black layer is on top

[Zebra2711]

cause by :

monitorv2 {
    output = eDP-1
    mode = 1920x1080@144
    position = 0x0
    scale = 1
    cm = srgb
    sdrbrightness = 2.20
    sdrsaturation = 1.07
    supports_wide_color = 1
    supports_hdr = 0
    sdr_min_luminance = 0.005
    sdr_max_luminance = 200
    min_luminance = 0
    max_luminance = 1000 <---- this
    max_avg_luminance = 200 <---- this
}

[vaxerski]

@UjinT34 maybe max_luminance here is somehow clamped, and then when multiplying it's fine because it clamps (e.g. 0.1 * 1000 = 100 -> clamped to 1.0) but when going back it gets fucked (1 / 1000 = 0.001)

[vaxerski]

patch.txt

maybe this will just fix it to an acceptable level?

[doomperfect]

Yeppppp! That's it lol, good catch, commenting out all those lines fixes it for me too.

	# supports_wide_color = 1
	# supports_hdr = 1
	# sdr_min_luminance = 0.005
	# sdr_max_luminance = 400
	# min_luminance = 0
	# max_luminance = 1000
	# max_avg_luminance = 300

Btw discovered another unrelated thing that may be unintended, commenting out just the min/max/max_avg luminance lines, but leaving in the sdr_min and sdr_max lines, messes up whole desktop colours in 10bit wide/edid mode (srgb is ok tho). But I thought all of these settings were not supposed to do anything in non-hdr modes?

[Zebra2711]

patch.txt

maybe this will just fix it to an acceptable level?

Yes, that fixed the issue

[vaxerski]

pushed to main, enjoy

[doomperfect]

goated, ty