Missing xdg_foreign support (used to be in Hyprland but was removed with wlroots)

[rmunn]

When running GIMP, I see the following message at startup time:

(gimp:1916940): Gdk-WARNING **: 11:35:04.688: Server is missing xdg_foreign support
gimp_widget_set_handle_on_mapped: gdk_wayland_window_export_handle() failed. It will not be possible to set windows in other processes as transient to this display shell.

The xdg_foreign protocol used to be supported in Hyprland, but it used the wlr_xdg_foreign_registry_create function from wlroots to implement that protocol. That was probably removed when wlroots was removed; the string xdg_foreign no longer appears in the Hyprland source code.

Nearly everything in GIMP appears to be working fine without xdg_foreign support, but there is one issue: when I go to export an image, GIMP tries to pop up a pre-save dialog with properties like compression level, and so on. This dialog is, I gather, supposed to pop up above the GIMP window so that it will be noticed, but because Hyprland doesn't currently implement xdg_foreign, it appears as another tiled window instead. Since I often have GIMP running maximised, I don't always notice the tiled window until I un-maximise GIMP.

[vaxerski]

xdg_foreign is not very useful in Hyprland's case, and the support will likely not change much. I mean, the tiled popup might be fixed, but it's really minor, isnt it

[rmunn]

It should be minor, but not seeing the popup when I have GIMP maximised has actually caused me to lose data at least once, when I later closed the maximised GIMP window without realizing that the file I saved wasn't actually saved yet. GIMP's workflow is that you choose a filename, then based on the extension it shows you a popup window with the JPEG options or the PNG options or whatever format, and when you click OK on that window, then the file is saved. At least once I saved a file as JPG, didn't see the popup (because the main GIMP window was maximised and the popup didn't appear above it), then closed the window. Thankfully what I was doing at the time was simply resizing some photos and I still had the originals, so I could just recreate the lost work in 1 minute. But there was actually potential there for losing a lot more work than 1 minute's worth.

I'm not saying that xdg_foreign needs to be high priority. But there's at least one commonly-used app where not having it does cause potential issues. Granted, it was user error, but that user error would be reduced if GIMP was able to pop up its window above the main window the way it was trying to.

[vaxerski]

mhm, I getchu.

[vaxerski]

#11229