Memory leak in HookSystem.cpp

[carabistouflette]

HookSystem.cpp:185-250: free() called on a null pointer

Current problem

m_originalBytes = nullptr;
free(m_originalBytes); // Frees nullptr!

The code first sets the pointer m_originalBytes to nullptr (making it a null pointer). Then, it calls free() on this null pointer. While calling free() on a null pointer is technically safe (as it does nothing), the logical order is incorrect. The original memory address stored in m_originalBytes is lost before the attempt to free it, creating a memory leak.

Fix

free(m_originalBytes);
m_originalBytes = nullptr;

[vaxerski]

manual memory management as usual comes to bite me in the

Promoted #10790