Potential Screen Shader Regression

[RANKSHANK]

#10364 seems to have broken screen shaders. I've loaded up the three most recent commits in separate ttys as shown below, and both sessions with the #10364 changes applied remain frozen until the configuration is updated with the shader disabled. If the config is updated with the shader enabled afterwards, the screen remains frozen on the last frame before the configuration was applied.

Tested with the simplest possible frag shader below, same result.

precision mediump float;
varying vec2 v_texcoord;
uniform sampler2D tex;
void main()
{
    vec4 base_color = texture2D(tex, v_texcoord);
    gl_FragColor = base_color;
}

System Info:

System Information:
System name: Linux
Node name: ranklaptop
Release: 6.14.5-xanmod1
Version: #1-NixOS SMP PREEMPT_DYNAMIC Tue Jan  1 00:00:00 UTC 1980


GPU information:
00:02.0 VGA compatible controller [0300]: Intel Corporation HD Graphics 630 [8086:591b] (rev 04) (prog-if 00 [VGA controller])
01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GP106M [GeForce GTX 1060 Mobile] [10de:1c20] (rev a1) (prog-if 00 [VGA controller])
NVRM version: NVIDIA UNIX x86_64 Kernel Module  575.51.02  Thu Apr 10 16:08:06 UTC 2025


os-release: ANSI_COLOR="0;38;2;126;186;228"
BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="25.05.20250510.d89fc19"
CPE_NAME="cpe:/o:nixos:nixos:25.05"
DEFAULT_HOSTNAME=nixos
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
ID_LIKE=""
IMAGE_ID=""
IMAGE_VERSION=""
LOGO="nix-snowflake"
NAME=NixOS
PRETTY_NAME="NixOS 25.05 (Warbler)"
SUPPORT_URL="https://nixos.org/community.html"
VARIANT=""
VARIANT_ID=""
VENDOR_NAME=NixOS
VENDOR_URL="https://nixos.org/"
VERSION="25.05 (Warbler)"
VERSION_CODENAME=warbler
VERSION_ID="25.05"


plugins:

[gulafaran]

solves it? seems i missed a place of creating vertex array objects

made it work in nested but.

diff --git a/src/render/OpenGL.cpp b/src/render/OpenGL.cpp
index 7739dff1..7d273d1c 100644
--- a/src/render/OpenGL.cpp
+++ b/src/render/OpenGL.cpp
@@ -1262,6 +1262,7 @@ void CHyprOpenGLImpl::applyScreenShader(const std::string& path) {
     }
     m_finalScreenShader.texAttrib = glGetAttribLocation(m_finalScreenShader.program, "texcoord");
     m_finalScreenShader.posAttrib = glGetAttribLocation(m_finalScreenShader.program, "pos");
+    m_finalScreenShader.createVao();
 }
 
 void CHyprOpenGLImpl::clear(const CHyprColor& color) {

[RANKSHANK]

Can confirm that fixes my issues, thanks!