Skip to content

SelectNext: cap listbox's max height to available space #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
acelaya opened this issue Oct 10, 2023 · 1 comment
Closed

SelectNext: cap listbox's max height to available space #1301

acelaya opened this issue Oct 10, 2023 · 1 comment

Comments

@acelaya
Copy link
Contributor

acelaya commented Oct 10, 2023

SelectNext implements some logic that makes the listbox drop up or down depending on where there's more available space.

However, the max height is "hardcoded" (via tailwind class), which means it can partially render out of the viewport.

It would be good to calculate not only where there's more space (in order to decide if it should drop up or down), but also check the available space, and set a max height which is slightly smaller.

@acelaya
Copy link
Contributor Author

acelaya commented Mar 24, 2025

Superseded by #1921

@acelaya acelaya closed this as completed Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants