Reduce duplication between vitest and rollup-tests config files

Author: acelaya

package.json

@@ -11,7 +11,7 @@
     "@babel/preset-react": "^7.0.0",
     "@babel/preset-typescript": "^7.18.6",
     "@hypothesis/frontend-build": "^4.0.0",
-    "@hypothesis/frontend-testing": "^1.6.0",
+    "@hypothesis/frontend-testing": "^1.7.1",
     "@rollup/plugin-babel": "^6.0.0",
     "@rollup/plugin-commonjs": "^28.0.0",
     "@rollup/plugin-dynamic-import-vars": "^2.1.2",

rollup-tests.config.js

@@ -1,9 +1,19 @@
+import { vitestCoverageOptions } from '@hypothesis/frontend-testing/vitest';
 import { babel } from '@rollup/plugin-babel';
 import commonjs from '@rollup/plugin-commonjs';
 import { nodeResolve } from '@rollup/plugin-node-resolve';
 import virtual from '@rollup/plugin-virtual';
 import { string } from 'rollup-plugin-string';
 
+export const excludeFromCoverage = [
+  '**/node_modules/**',
+  '**/test/**/*.js',
+  '**/test-util/**',
+  'src/components/icons/**/*.ts*',
+  'src/pattern-library/**/*.js',
+  'src/pattern-library/**/*.ts*',
+];
+
 export default {
   input: 'build/scripts/test-inputs.js', // Input file generated by gulp task
   output: {
@@ -66,23 +76,8 @@ export default {
         [
           'babel-plugin-istanbul',
           {
-            // This needs to match the value set in coverage.exclude in vitest.config.js
-            exclude: [
-              '**/node_modules/**',
-              '**/test/**/*.js',
-              '**/test-util/**',
-              'src/components/icons/**/*.ts*',
-              'src/pattern-library/**/*.js',
-              'src/pattern-library/**/*.ts*',
-            ],
-
-            // These two configuration options needed to match the values that
-            // vitest sets internally, so that they pick the coverage
-            // instrumentation generated by babel-plugin-istanbul instead of
-            // trying to generate their own.
-            // See https://github.com/vitest-dev/vitest/discussions/7841#discussioncomment-12855608
-            coverageGlobalScope: 'globalThis',
-            coverageVariable: '__VITEST_COVERAGE__',
+            ...vitestCoverageOptions,
+            exclude: excludeFromCoverage,
           },
         ],
       ],

vitest.config.js

@@ -1,6 +1,8 @@
 import { SummaryReporter } from '@hypothesis/frontend-testing/vitest';
 import { defineConfig } from 'vitest/config';
 
+import { excludeFromCoverage } from './rollup-tests.config.js';
+
 export default defineConfig({
   test: {
     globals: true,
@@ -28,14 +30,7 @@ export default defineConfig({
       reportsDirectory: './coverage',
       reporter: ['json', 'html'],
       include: ['src/**/*.{ts,tsx}'],
-      exclude: [
-        '**/node_modules/**',
-        '**/test/**/*.js',
-        '**/test-util/**',
-        'src/components/icons/**/*.ts*',
-        'src/pattern-library/**/*.js',
-        'src/pattern-library/**/*.ts*',
-      ],
+      exclude: excludeFromCoverage,
     },
   },
 });

yarn.lock

@@ -1792,7 +1792,7 @@ __metadata:
     "@babel/preset-react": ^7.0.0
     "@babel/preset-typescript": ^7.18.6
     "@hypothesis/frontend-build": ^4.0.0
-    "@hypothesis/frontend-testing": ^1.6.0
+    "@hypothesis/frontend-testing": ^1.7.1
     "@rollup/plugin-babel": ^6.0.0
     "@rollup/plugin-commonjs": ^28.0.0
     "@rollup/plugin-dynamic-import-vars": ^2.1.2
@@ -1843,19 +1843,16 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@hypothesis/frontend-testing@npm:^1.6.0":
-  version: 1.6.0
-  resolution: "@hypothesis/frontend-testing@npm:1.6.0"
+"@hypothesis/frontend-testing@npm:^1.7.1":
+  version: 1.7.1
+  resolution: "@hypothesis/frontend-testing@npm:1.7.1"
   dependencies:
     axe-core: ^4.8.2
     enzyme: ^3.11.0
     preact: ^10.18.1
   peerDependencies:
     vitest: ^3.1.2
-  peerDependenciesMeta:
-    vitest:
-      optional: true
-  checksum: 1ac5404bc658bbf1c71548d39e4703ac65ec822794f0a654122b7c98767f3f5830449466ee4c46695a44bd03a65b35108dddc3d8d7b177eb738b11a34c4f38e7
+  checksum: 94c8232c1968797370716e68c922741d5dc301fc7c27980257b5f0662837c00ed9312f32439538d5417ed68e9410096979fab8dd196045668c0d662a843ca6df
   languageName: node
   linkType: hard