🐛 Fixes publishing scripts

Author: danieldelcore

.github/workflows/release-all-codemods.yml

@@ -18,6 +18,7 @@ jobs:
         uses: actions/setup-node@v1
         with:
           node-version: ${{ matrix.node-version }}
+          registry-url: https://registry.npmjs.org/
       - run: yarn install --frozen-lockfile
       - run: yarn validate
       - run: yarn test
@@ -26,3 +27,4 @@ jobs:
         env:
           CI: true
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

.github/workflows/release-codemods.yml

@@ -20,6 +20,7 @@ jobs:
         uses: actions/setup-node@v1
         with:
           node-version: ${{ matrix.node-version }}
+          registry-url: https://registry.npmjs.org/
       - run: yarn install --frozen-lockfile
       - run: yarn validate
       - run: yarn test
@@ -28,3 +29,4 @@ jobs:
         env:
           CI: true
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

packages/publisher/package.json

@@ -8,10 +8,12 @@
   "dependencies": {
     "@codeshift/initializer": "*",
     "@preconstruct/cli": "^2.0.0",
+    "chalk": "^4.1.0",
     "fs-extra": "^9.1.0",
     "npm-registry-client": "^8.6.0",
     "semver": "^7.3.5",
     "simple-git": "^2.37.0",
+    "spawndamnit": "^2.0.0",
     "tar": "^6.1.0",
     "ts-node": "^9.1.1"
   }

packages/publisher/src/build.ts

@@ -5,9 +5,9 @@ export default function buildPackages(path: string, packages: string[]) {
     packages.map(
       pkg =>
         new Promise<void>((resolve, reject) => {
-          // TODO: stop this from building the entire repo.
           exec(
-            `echo $PWD && cd ${path}/${pkg} && yarn build`,
+            `yarn build`,
+            { cwd: `${path}/${pkg}` },
             (error, stdout, stderr) => {
               if (error) {
                 console.error(`exec error: ${error}`);

packages/publisher/src/publish.ts

@@ -1,68 +1,86 @@
 import fs from 'fs-extra';
-import tar from 'tar';
-
+import chalk from 'chalk';
 // @ts-ignore
-import RegClient from 'npm-registry-client';
-
-// TODO: dependency inject this instance
-const client = new RegClient();
-const npmUri = 'https://registry.npmjs.org/';
+import spawn from 'spawndamnit';
 
-interface PublishPackageOptions {
-  metadata: Record<string, string>;
-  access: 'public' | 'restricted';
-  token: string;
-  body: any;
+function jsonParse(input: string) {
+  try {
+    return JSON.parse(input);
+  } catch (err) {
+    if (err instanceof SyntaxError) {
+      console.error('error parsing json:', input);
+    }
+    throw err;
+  }
 }
 
-function publishPackage(
-  packageName: string,
-  { metadata, access, body, token }: PublishPackageOptions,
+async function publish(
+  pkg: { dir: string; packageJson: Record<string, any> },
+  opts: { dry?: boolean },
+  authToken: string,
 ) {
-  return new Promise<void>((resolve, reject) =>
-    client.publish(
-      npmUri,
-      { metadata, access, body, auth: { token } },
-      (error: any) => {
-        if (error) {
-          reject(
-            `Unexpected error when publishing ${packageName} to NPM: ${error}`,
-          );
-        }
-        resolve();
-      },
-    ),
+  const { name, version } = pkg.packageJson;
+
+  console.log(
+    `Publishing ${chalk.cyan(`"${name}"`)} at ${chalk.green(`"${version}"`)}`,
   );
+
+  // Due to a super annoying issue in yarn, we have to manually override this env variable
+  // See: https://github.com/yarnpkg/yarn/issues/2935#issuecomment-355292633
+  const envOverride = {
+    // eslint-disable-next-line @typescript-eslint/camelcase
+    npm_config_registry: `//registry.npmjs.org/:_authToken=${authToken}`,
+  };
+
+  const publishOpts = ['--access', 'public'];
+
+  if (opts?.dry) {
+    publishOpts.push('--dry-run');
+  }
+
+  const { stdout } = await spawn(
+    'npm',
+    ['publish', pkg.dir, '--json', ...publishOpts],
+    {
+      env: Object.assign({}, process.env, envOverride),
+    },
+  );
+
+  const json = jsonParse(stdout.toString().replace(/[^{]*/, ''));
+
+  if (json.error) {
+    throw new Error(
+      `An error occurred while publishing ${name}: ${json.error.code}
+${json.error.summary}
+${json.error.detail ? '\n' + json.error.detail : ''}
+      `,
+    );
+  }
 }
 
-export default function publishPackages(path: string, authToken: string) {
+export default function publishPackages(
+  path: string,
+  opts: { dry?: boolean },
+  authToken: string,
+) {
   return Promise.all(
     fs.readdirSync(path).map(async dir => {
-      const packageName = `@codeshift/mod-${dir
-        .replace('@', '')
-        .replace('/', '__')}`;
       const packagePath = `${path}/${dir}`;
-      const packageJson = await fs.readFile(`${packagePath}/package.json`);
-      const tarballPath = `${packagePath}/tarball.tgz`;
+      const packageJson = await fs.readFile(
+        `${packagePath}/package.json`,
+        'utf8',
+      );
 
-      await tar.create(
+      await publish(
         {
-          cwd: packagePath,
-          file: tarballPath,
-          gzip: true,
+          dir: packagePath,
+          packageJson: jsonParse(packageJson),
         },
-        ['.'],
+        opts,
+        authToken,
       );
-
-      await publishPackage(packageName, {
-        // @ts-ignore
-        metadata: JSON.parse(packageJson),
-        access: 'public',
-        body: fs.createReadStream(tarballPath),
-        token: authToken,
-      });
     }),
-  ).catch(err => {
-    throw new Error(err);
+  ).catch(error => {
+    throw new Error(error);
   });
 }

scripts/publish-all-dry.ts

@@ -2,6 +2,7 @@ import {
   getAllPackages,
   buildPackages,
   generatePackages,
+  publishPackages,
   cleanTargetDir,
 } from '@codeshift/publisher';
 
@@ -15,6 +16,9 @@ async function main(sourcePath: string, targetPath: string) {
 
   console.log('🏗 Building all packages');
   await buildPackages(targetPath, packages);
+
+  console.log('📦 Publishing changed packages (dry)');
+  await publishPackages(targetPath, { dry: true }, process.env.NPM_TOKEN!);
 }
 
 main(process.argv[2], process.argv[3]).catch(error => {

scripts/publish-all.ts

@@ -17,8 +17,8 @@ async function main(sourcePath: string, targetPath: string) {
   console.log('🏗 Building all packages');
   await buildPackages(targetPath, packages);
 
-  await publishPackages(targetPath, process.env.NPM_TOKEN!);
   console.log('📦 Publishing all packages');
+  await publishPackages(targetPath, {}, process.env.NPM_TOKEN!);
 
   console.log('🧹 Cleaning up temporary directory');
   cleanTargetDir(targetPath);

scripts/publish.ts

@@ -28,7 +28,7 @@ async function main(sourcePath: string, targetPath: string) {
   await buildPackages(targetPath, changedPackages);
 
   console.log('📦 Publishing changed packages');
-  await publishPackages(targetPath, process.env.NPM_TOKEN!);
+  await publishPackages(targetPath, {}, process.env.NPM_TOKEN!);
 
   console.log('🧹 Cleaning up temporary directory');
   cleanTargetDir(targetPath);