Skip to content

Commit db86e55

Browse files
weihangloseanmonstar
authored andcommitted
test(benches): update server benchmark to async/await
1 parent 63a8f26 commit db86e55

File tree

2 files changed

+40
-36
lines changed

2 files changed

+40
-36
lines changed

Cargo.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,10 +156,10 @@ name = "pipeline"
156156
path = "benches/pipeline.rs"
157157
required-features = ["runtime"]
158158

159-
#[[bench]]
160-
#name = "server"
161-
#path = "benches/server.rs"
162-
#required-features = ["runtime"]
159+
[[bench]]
160+
name = "server"
161+
path = "benches/server.rs"
162+
required-features = ["runtime"]
163163

164164

165165
#[[test]]

benches_disabled/server.rs renamed to benches/server.rs

Lines changed: 36 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,49 +1,54 @@
1+
#![feature(async_await)]
12
#![feature(test)]
2-
#![deny(warnings)]
3+
//#![deny(warnings)]
34

4-
extern crate futures;
5-
extern crate hyper;
6-
extern crate pretty_env_logger;
75
extern crate test;
8-
extern crate tokio;
96

107
use std::io::{Read, Write};
118
use std::net::{TcpListener, TcpStream};
129
use std::sync::mpsc;
10+
use std::time::Duration;
1311

14-
use futures::{stream, Future, Stream};
15-
use futures::sync::oneshot;
12+
use futures_util::{stream, StreamExt};
13+
use tokio::runtime::current_thread;
14+
use tokio::sync::oneshot;
1615

1716
use hyper::{Body, Response, Server};
18-
use hyper::service::service_fn_ok;
17+
use hyper::service::{make_service_fn, service_fn};
1918

2019
macro_rules! bench_server {
2120
($b:ident, $header:expr, $body:expr) => ({
2221
let _ = pretty_env_logger::try_init();
2322
let (_until_tx, until_rx) = oneshot::channel::<()>();
2423
let addr = {
2524
let (addr_tx, addr_rx) = mpsc::channel();
26-
::std::thread::spawn(move || {
25+
std::thread::spawn(move || {
2726
let addr = "127.0.0.1:0".parse().unwrap();
27+
let make_svc = make_service_fn(|_| async {
28+
Ok::<_, hyper::Error>(service_fn(|_| async {
29+
Ok::<_, hyper::Error>(Response::builder()
30+
.header($header.0, $header.1)
31+
.header("content-type", "text/plain")
32+
.body($body())
33+
.unwrap()
34+
)
35+
}))
36+
});
2837
let srv = Server::bind(&addr)
29-
.serve(|| {
30-
let header = $header;
31-
let body = $body;
32-
service_fn_ok(move |_| {
33-
Response::builder()
34-
.header(header.0, header.1)
35-
.header("content-type", "text/plain")
36-
.body(body())
37-
.unwrap()
38-
})
39-
});
38+
.serve(make_svc);
39+
4040
addr_tx.send(srv.local_addr()).unwrap();
41-
let fut = srv
42-
.map_err(|e| panic!("server error: {}", e))
43-
.select(until_rx.then(|_| Ok(())))
44-
.then(|_| Ok(()));
45-
let mut rt = tokio::runtime::current_thread::Runtime::new().unwrap();
46-
rt.spawn(fut);
41+
42+
let graceful = srv
43+
.with_graceful_shutdown(async {
44+
until_rx.await.ok();
45+
});
46+
let mut rt = current_thread::Runtime::new().unwrap();
47+
rt.spawn(async {
48+
if let Err(e) = graceful.await {
49+
panic!("server error: {}", e);
50+
}
51+
});
4752
rt.run().unwrap();
4853
});
4954

@@ -58,7 +63,7 @@ macro_rules! bench_server {
5863
};
5964

6065
let mut tcp = TcpStream::connect(addr).unwrap();
61-
tcp.set_read_timeout(Some(::std::time::Duration::from_secs(3))).unwrap();
66+
tcp.set_read_timeout(Some(Duration::from_secs(3))).unwrap();
6267
let mut buf = [0u8; 8192];
6368

6469
$b.bytes = 35 + total_bytes as u64;
@@ -91,7 +96,7 @@ fn throughput_fixedsize_large_payload(b: &mut test::Bencher) {
9196
fn throughput_fixedsize_many_chunks(b: &mut test::Bencher) {
9297
bench_server!(b, ("content-length", "1000000"), || {
9398
static S: &'static [&'static [u8]] = &[&[b'x'; 1_000] as &[u8]; 1_000] as _;
94-
Body::wrap_stream(stream::iter_ok::<_, String>(S.iter()).map(|&s| s))
99+
Body::wrap_stream(stream::iter(S.iter()).map(|&s| Ok::<_, String>(s)))
95100
})
96101
}
97102

@@ -109,7 +114,7 @@ fn throughput_chunked_large_payload(b: &mut test::Bencher) {
109114
fn throughput_chunked_many_chunks(b: &mut test::Bencher) {
110115
bench_server!(b, ("transfer-encoding", "chunked"), || {
111116
static S: &'static [&'static [u8]] = &[&[b'x'; 1_000] as &[u8]; 1_000] as _;
112-
Body::wrap_stream(stream::iter_ok::<_, String>(S.iter()).map(|&s| s))
117+
Body::wrap_stream(stream::iter(S.iter()).map(|&s| Ok::<_, String>(s)))
113118
})
114119
}
115120

@@ -118,7 +123,7 @@ fn raw_tcp_throughput_small_payload(b: &mut test::Bencher) {
118123
let (tx, rx) = mpsc::channel();
119124
let listener = TcpListener::bind("127.0.0.1:0").unwrap();
120125
let addr = listener.local_addr().unwrap();
121-
::std::thread::spawn(move || {
126+
std::thread::spawn(move || {
122127
let mut sock = listener.accept().unwrap().0;
123128

124129
let mut buf = [0u8; 8192];
@@ -160,7 +165,7 @@ fn raw_tcp_throughput_large_payload(b: &mut test::Bencher) {
160165
Date: Fri, 12 May 2017 18:21:45 GMT\r\n\
161166
\r\n\
162167
";
163-
::std::thread::spawn(move || {
168+
std::thread::spawn(move || {
164169
let mut sock = listener.accept().unwrap().0;
165170

166171
let mut buf = [0u8; 8192];
@@ -190,4 +195,3 @@ fn raw_tcp_throughput_large_payload(b: &mut test::Bencher) {
190195
});
191196
tx.send(()).unwrap();
192197
}
193-

0 commit comments

Comments
 (0)