fix: expandToNestedObject method bug (inconsistent top-level keys) (#551)

Author: wrn14897

.changeset/good-parrots-sing.md

@@ -0,0 +1,5 @@
+---
+"@hyperdx/api": patch
+---
+
+fix: expandToNestedObject method bug (inconsistent top-level keys)

packages/api/src/tasks/__tests__/checkAlerts.test.ts

@@ -99,6 +99,23 @@ describe('checkAlerts', () => {
     expect(expandToNestedObject({ 'foo.bar.baz': 'qux' })).toEqual({
       foo: { bar: { baz: 'qux' } },
     });
+    // inconsistent top level keys
+    expect(
+      expandToNestedObject({
+        foo: 'bar',
+        'foo.bar': 'baz',
+      }),
+    ).toEqual({
+      foo: 'bar',
+    });
+    expect(
+      expandToNestedObject({
+        'foo.bar': 'baz',
+        foo: 'bar',
+      }),
+    ).toEqual({
+      foo: 'bar',
+    });
     // mix
     expect(
       expandToNestedObject({

packages/api/src/tasks/checkAlerts.ts

@@ -126,11 +126,16 @@ export const expandToNestedObject = (
           break;
         }
         const nestedKey = keys[i];
-        if (i === keys.length - 1) {
-          nestedObj[nestedKey] = obj[key];
-        } else {
-          nestedObj[nestedKey] = nestedObj[nestedKey] || {};
-          nestedObj = nestedObj[nestedKey];
+        try {
+          if (i === keys.length - 1) {
+            nestedObj[nestedKey] = obj[key];
+          } else {
+            nestedObj[nestedKey] = nestedObj[nestedKey] || {};
+            nestedObj = nestedObj[nestedKey];
+          }
+        } catch (e) {
+          // skip the duplicate inconsistent top level keys case. ex: 'foo' and 'foo.bar'
+          logger.warn('expandToNestedObject', e);
         }
       }
     }