Skip to content

Commit e2ec772

Browse files
author
Pablo Orgaz
committed
Make subscribe function private
1 parent 10f1be6 commit e2ec772

File tree

3 files changed

+11
-25
lines changed

3 files changed

+11
-25
lines changed

app/src/main/java/org/sample/SampleActivity.kt

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,10 @@ import com.mini.android.FluxActivity
55
import com.minikorp.grove.ConsoleLogTree
66
import com.minikorp.grove.Grove
77
import kotlinx.android.synthetic.main.home_activity.*
8-
import mini.*
8+
import mini.Action
9+
import mini.LoggerInterceptor
10+
import mini.MiniGen
11+
import mini.Store
912

1013
class SampleActivity : FluxActivity() {
1114

@@ -29,32 +32,17 @@ class SampleActivity : FluxActivity() {
2932
Grove.tag(tag).d { msg }
3033
}))
3134

32-
dispatcher.dispatch(ActionOne(""))
3335
dispatcher.dispatch(ActionTwo("2"))
3436
}
3537
}
3638

39+
@Action
3740
interface ActionInterface {
3841
val text: String
3942
}
4043

41-
abstract class SampleAbstractAction : BaseAction()
42-
43-
data class ActionOne(override val text: String) : ActionInterface, SampleAbstractAction()
44-
45-
@Action class ActionTwo(val text: String)
44+
@Action
45+
class ActionTwo(override val text: String) : ActionInterface
4646

4747
data class DummyState(val text: String = "dummy")
48-
class DummyStore : Store<DummyState>() {
49-
50-
@Reducer fun onInterfaceAction(a: ActionInterface) {
51-
}
52-
53-
@Reducer fun onSampleAction(a: ActionOne) {
54-
newState = state.copy(text = a.text)
55-
}
56-
57-
@Reducer fun anotherAction(a: ActionTwo) {
58-
state.copy(text = a.text).asNewState()
59-
}
60-
}
48+
class DummyStore : Store<DummyState>()

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
buildscript {
22
ext {
33
kotlin_version = "1.3.41"
4-
mini_version = "4.0.3"
4+
mini_version = "4.0.4"
55
}
66

77
repositories {

mini-processor/src/main/java/mini/processor/ReducersGenerator.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
package mini.processor
22

3-
import com.squareup.kotlinpoet.CodeBlock
4-
import com.squareup.kotlinpoet.FunSpec
3+
import com.squareup.kotlinpoet.*
54
import com.squareup.kotlinpoet.ParameterizedTypeName.Companion.parameterizedBy
6-
import com.squareup.kotlinpoet.TypeSpec
7-
import com.squareup.kotlinpoet.asTypeName
85
import mini.CompositeCloseable
96
import mini.Dispatcher
107
import mini.Reducer
@@ -44,6 +41,7 @@ object ReducersGenerator {
4441
.build()
4542

4643
val registerOneFn = FunSpec.builder("subscribe")
44+
.addModifiers(KModifier.PRIVATE)
4745
.addParameter("dispatcher", Dispatcher::class)
4846
.addParameter("container", reducerContainerType)
4947
.returns(Closeable::class)

0 commit comments

Comments
 (0)