Skip to content

Conversation

@severo
Copy link
Contributor

@severo severo commented Oct 17, 2025

WDYT @platypii? It's a simple change, but I think it works better.

Screencast.From.2025-10-17.11-07-50.mp4

The only objection might be that an array of very small strings, eg: ['a', 'b'] would be better collapsed than expanded by default. But it would require a bit more complexity in the heuristic, and I'm not sure we would see this kind of data too often

@severo severo requested review from Copilot and platypii October 17, 2025 09:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the JSON collapse/expand heuristic by treating strings as non-primitive values, causing arrays and objects containing strings to be expanded by default rather than collapsed. This improves the default viewing experience for string-containing data structures.

Key Changes:

  • Modified isPrimitive() to exclude strings from primitive classification
  • Updated test descriptions and cases to reflect the new string handling behavior
  • Minor CI workflow improvement to restrict push triggers to master branch

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/components/Json/helpers.ts Excludes strings from primitive classification in the isPrimitive() function
src/components/Json/Json.test.tsx Updates tests to verify new string-handling behavior and adjusts test descriptions
.github/workflows/ci.yml Restricts push-triggered CI runs to master branch and removes trailing whitespace

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup looks better! 👍

@severo severo merged commit 81fdaf3 into master Oct 18, 2025
4 checks passed
@severo severo deleted the json-heuristic branch October 18, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants