JSON heuristic: don't consider strings as primitive #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WDYT @platypii? It's a simple change, but I think it works better.
Screencast.From.2025-10-17.11-07-50.mp4
The only objection might be that an array of very small strings, eg:
['a', 'b']would be better collapsed than expanded by default. But it would require a bit more complexity in the heuristic, and I'm not sure we would see this kind of data too often