Skip to content

Commit 786b5ae

Browse files
committed
prevent valuechanged triggered twice
1 parent ec53392 commit 786b5ae

File tree

4 files changed

+38
-19
lines changed

4 files changed

+38
-19
lines changed

Changelog.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,28 @@
11
# Changelog
22

33

4+
## 2021-10-22 1.9.0
5+
* DROP SUPPORT FOR JAVA-8. java-8 does not support tiff. I used an external lib (twelvemonkeys) to support tif, but twelvemonkeys also moves on and tiff support using java-8 gets more and more cumbersome. Java-11 and up supports tiff out of the box. Dropping Twelvemonkeys also means that pgm/pict/tga is no longer supported (but who uses that anyway).
6+
* ["feature request" #156](https://github.com/hvdwolf/jExifToolGUI/issues/156): Create setting where users can define their own font and font size for the application to accomodate higher (hdpi) resolutions.
7+
* ["feature request" #117](https://github.com/hvdwolf/jExifToolGUI/issues/117): Option to "switch of" thumbnail generation and metadata reading when loading images. This can speed up the image loading 400% to almost instantly. When switching off "Create previews", always one preview is created in the bottom-left. Either the first of the loaded set, or the image selected from the list.
8+
* Added option in the "Export/Import" pane and the "Exiftool Commands" pane to specify a folder instead of loading previews. Especially when dealing with large amounts of images, this is really fast when comparing it with first loading the images, creating previews. Next to that: some exiftool commands work faster when done on a folder in comparison to "image by image".
9+
* Display the source folder in the bottom notification bar. It already displayed the number of loaded files. It now displays the folder as well. Note: This will not work correctly when dropping files from multiple folders on the program, or specifying multiple folders/files on the command line.
10+
* Support fast-scaling when resizing. As java-8 is no longer supported I can use higher level image resizing/rescaling functionality. This should give some 5-15% performance improvement on loading.
11+
* Support for photoshop thumbnails added. Photoshop tiffs containing these thumbnails now load the preview at least 25~50x faster (because we no longer need to resize the entire sometimes 45+ MB image).
12+
* Search in metadata of loaded images (added a magnifying glass button). You can search on tag and on value. Images that contain search results can be reloaded.
13+
* Add vrae config and vrae custom metadataset
14+
* Display filename/path above metadata panel
15+
* Add menu option for "set file date to create date" for mp4/mov movieclips
16+
* [MacOS] Fix ["issue #118"](https://github.com/hvdwolf/jExifToolGUI/issues/170): "sips conversion of heic images". Only the first occurrence of multiple spaces in path/filename were escaped.
17+
* Updated splash logo to display Exif, GPS and XMP in uppercase instead of Exif, gps and xmp.
18+
* Fix null pointer assignment in geotagging
19+
* Fix Set to DateTimeOriginal: spaces in exiftool path caused error
20+
* Fix ["issue" #110](https://github.com/hvdwolf/jExifToolGUI/issues/110) (windows): If PATH contains multiple exiftool versions, jExifToolGUI crashes. Fixed now.
21+
* Fix ["issue" #116](https://github.com/hvdwolf/jExifToolGUI/issues/116) (windows): ExifTool command will not run if exiftool.exe directory contains a space.
22+
* ["issue" #100](https://github.com/hvdwolf/jExifToolGUI/issues/100): Add "-m" parameter to Edit->GPS tab to allow for longer than 32 character strings for IPTC. Make it checked by default.
23+
* ["feature request" #124](https://github.com/hvdwolf/jExifToolGUI/issues/124): Convenient localization (translation) using Weblate
24+
* GPS: Add "Add location to makernotes". Many camera's have location,country,state,city as makernotes. Exiftool will automatically put it in the correct Panasonic/Canon/Nikon/etcetera tags.
25+
426
## 2020-12-09 1.8.1
527
* [issue #99](https://github.com/hvdwolf/jExifToolGUI/issues/99): 3 issues > GPS edition.
628
* [issue #98](https://github.com/hvdwolf/jExifToolGUI/issues/98): Focal length in 35 mm shown as null. Fixed for cameras that do not provide the "FocalLengthIn35mmFormat". All cameras provide the "ScaleFactor35efl". Combined with the "FocalLength" one can calculate the "FocalLengthIn35mmFormat".

src/main/java/org/hvdw/jexiftoolgui/ProgramTexts.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ public class ProgramTexts {
66
*/
77
public static final String Author = "Harry van der Wolf";
88
public static final String ProjectWebSite = "http://hvdwolf.github.io/jExifToolGUI";
9-
public static final String Version = "1.8.2";
9+
public static final String Version = "1.9.0";
1010
public static final String HTML = "<html><body style='width: %1spx'>%1s";
1111
public static final String cancelledETlocatefromStartup = "<html>You cancelled providing the location of exiftool.<br>I will now exit jExifToolGUI.</html>";
1212
public static final String downloadInstallET = "I will now open the ExifTool website in your browser and then close jExifToolGUI.<br>"

src/main/java/org/hvdw/jexiftoolgui/mainScreen.java

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3711,20 +3711,17 @@ public void valueChanged(ListSelectionEvent e) {
37113711
selectedIndicesList = tmpselectedIndices;
37123712
MyVariables.setselectedIndicesList(selectedIndicesList);
37133713
MyVariables.setSelectedFilenamesIndices(selectedIndices);
3714-
if (!(createPreviewsCheckBox.isSelected())) { //No previews wanted, so only display preview in bottom-left for selected image
3714+
//No previews wanted, so only display preview in bottom-left for selected image
3715+
// and prevent 2nd event trigger
3716+
if ( (!(createPreviewsCheckBox.isSelected())) && (!e.getValueIsAdjusting()) ) {
3717+
Utils.selectedRowForSinglePreview();
37153718
Executor executor = Executors.newSingleThreadExecutor();
37163719
executor.execute(new Runnable() {
37173720
@Override
37183721
public void run() {
3719-
Utils.selectedRowForSinglePreview();
3722+
//Utils.selectedRowForSinglePreview();
37203723
Utils.displaySinglePreview(previewTable, loadMetadataCheckBox.isSelected());
3721-
Utils.progressStatus(progressBar, false);
3722-
}
3723-
});
3724-
SwingUtilities.invokeLater(new Runnable() {
3725-
public void run() {
3726-
progressBar.setVisible(true);
3727-
//progressPane(rootPanel, true);
3724+
//Utils.progressStatus(progressBar, false);
37283725
}
37293726
});
37303727
//Utils.selectedRowForSinglePreview();

src/main/resources/translations/program_strings.properties

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22
# jExiftoolGUI v1.9
33

44
#### Window/popup titles
5-
application.title=\ (for ExifTool by Phil Harvey)
5+
application.title=(for ExifTool by Phil Harvey)
66
preferences.title=Preferences
77
renamephotos.title=Rename Photos
88
createargsfile.title=Create args file(s)
99
exportmetadata.title=Export metadata
1010
removemetadata.title=Remove metadata
1111
favoriteaddquery.title=Add database query
12-
favoriteaddcommand.title=Add Exiftool command
12+
favoriteaddcommand.title=Add ExifTool command
1313
favoriteselect.title=Select a favorite
1414
createupdatelens.title=Create or update lens config
1515
selectlens.title=Select a lens config
@@ -341,7 +341,7 @@ copyd.copybyselection=Copy metadata using the selective group options mentioned
341341
copyd.copyexifcheckbox=Copy Exif data (-exif:all)
342342
copyd.copyxmpcheckbox=Copy XMP data (-xmp:all)
343343
copyd.copyiptccheckbox=Copy IPTC data (-iptc:all)
344-
copyd.copyicc_profilecheckbox=Copy ICC(_profile) data (-icc_profile:all)
344+
copyd.copyicc_profilecheckbox=Copy ICC profile (-icc_profile:all)
345345
copyd.copygpscheckbox=Copy GPS data (-gps:all)
346346
copyd.copyjfifcheckbox=Copy JFIF data (from the JPG JFIF header)
347347
copyd.copymakernotescheckbox=Copy makernotes (-makernotes:all)
@@ -403,9 +403,9 @@ prefs.checknewversion=Check for new jExifToolGUI version when starting the progr
403403
prefs.chkboxrawtitle=No RAW viewer selected
404404
prefs.chkboxrawtext=You can't set this as your default viewer without setting up a RAW viewer first.
405405
prefs.etlocatecanceltitle=Cancelled locating ExifTool
406-
prefs.etlocatecanceltext=You cancelled providing the location of ExifTool.<br>I will leave the current preference for what it is.
406+
prefs.etlocatecanceltext=You cancelled providing the location of ExifTool.<br>The current preference will be left as is.
407407
prefs.etwrongtitle=Wrong executable
408-
prefs.etwrongtext=This is not the ExifTool executable/binary.<br>I can't use it and will now exit jExifToolGUI.
408+
prefs.etwrongtext=This is not the ExifTool executable/binary.<br>It can not be used, and jExifToolGUI will exit.
409409
prefs.locateprefimgfolder=Locate preferred default image folder…
410410
prefs.locaterawviewer=Locate your preferred RAW image viewer…
411411
prefs.settingssaved=Settings saved
@@ -436,7 +436,7 @@ prefs.etprefincorrecttext=The ExifTool specified in your preferences does not ex
436436
rph.toptext=If you want to autonumber your images, make sure they are in the right alphabetical or date order. This is not a problem if you use the "Source folder" here,but can be a problem if you use the images from the main screen and if they are in "random" order.
437437
rph.sourcefolder=Source folder:
438438
rph.btnbrowse=Browse
439-
rph.selrenameoptions=Select rename options:
439+
rph.selrenameoptions=Select renaming options:
440440
rph.prefix=Prefix:
441441
rph.datetime=Date_time
442442
rph.date=Date
@@ -502,7 +502,7 @@ cmd.dlgtext=Copy all possible info from Exif and other tags into XMP format?<br>
502502
#### dialog remove metadata
503503
rmd.toptext=What metadata do you want to remove from your selected image(s)?<br>This screen is meant to remove all tags from a certain category from your selected images(s).<br>By writing "Clean empty fields" from the "Edit data" tabs you can clean that metadata specifically.
504504
rmd.removeall=Remove all metadata
505-
rmd.removeexif=Remove Exif data
505+
rmd.removeexif=Remove all Exif data
506506
rmd.removexmp=Remove all XMP data
507507
rmd.removegps=Remove all GPS data
508508
rmd.removeiptc=Remove all IPTC data
@@ -562,7 +562,7 @@ args.dlgcorrect=Is this correct?
562562

563563
#### Export all preview/thumbs
564564
ept.dlgtitle=Extract previews/thumbnails
565-
ept.dlgtext=This option will export all preview images and thumbnails from the slected images. This can only be done if your image(s) have them.<br>Continue?
565+
ept.dlgtext=This option will export all preview images and thumbnails from the selected images. This can only be done if your image(s) have them.<br>Continue?
566566
ept.exporterror=Could not create previews
567567

568568
#### Standard FileIO
@@ -600,7 +600,7 @@ mduc.dlgtitle=No custom metadata-set name given
600600
mduc.dlgtext=You did not provide a custom metadata-set name. Nothing to save/update.
601601
mduc.incompletetitle=Incorrect/incomplete data
602602
mduc.incompletetext=Populate the mandatory screen_label and/or tag fields.
603-
mduc.curdispcombi=Current displayed user combination:
603+
mduc.curdispcombi=Currently displayed user combination:
604604
mduc.lblcustconfig=Custom config (optional):
605605
mduc.locconfigfile=Locate custom config file…
606606
mduc.locatebutton=Select file

0 commit comments

Comments
 (0)