Possible bug when dropdown menus close #1302
Unanswered
brandonp-ais
asked this question in
Q&A
Replies: 4 comments 13 replies
-
|
Perhaps interesting update I still have not managed to make a repo I can share, BUT, I've confirmed that it is a specific version of svelte where the bug occurs: 5.23.0! When i downgrade my project before that, no problems. But upgrading to that version+ and get the issue. |
Beta Was this translation helpful? Give feedback.
2 replies
-
|
On the latest version of Svelte are you still able to reproduce? I'm not able to reproduce in my local environment |
Beta Was this translation helpful? Give feedback.
-
|
I've confirmed that removing svelte 4 compatibility fixed the problem in our large sveltekit application The lastest versions of svelte and bits-ui work with our app if that compiler option is not there, and breaks in the same way still if it is there . So the reproduction is just adding that option to svelte.config.js https://stackblitz.com/edit/egxubfvg?file=svelte.config.js Thanks so much! |
Beta Was this translation helpful? Give feedback.
-
|
I got the same error after updating svelte to 5.25.5. 
|
Beta Was this translation helpful? Give feedback.
2 replies
-
|
Are you running the latest version of bits as well? |
Beta Was this translation helpful? Give feedback.
-
|
If so please provide a reproduction via stackblitz (you can click the "open in stackblitz" on any demo on bits-ui.com) and I'll look. |
Beta Was this translation helpful? Give feedback.
-
|
Having the same issue when closing a Dialog. svelte 5.25.3, bits-ui 1.3.16 |
Beta Was this translation helpful? Give feedback.
9 replies
-
Oh, I just got it. Using svelte 5 in the compatibility mode breaks it. You can check out the stackblitz now. |
Beta Was this translation helpful? Give feedback.
-
|
Hmm…, @Wiblz quick question: Why do you have this in your compilerOptions: {
compatibility: {
componentApi: 4,
},
}, |
Beta Was this translation helpful? Give feedback.
-
|
@shyakadavis Some of the dependencies are still on svelte 4, comp mode is the only way to make it work. |
Beta Was this translation helpful? Give feedback.
-
|
I'm having the issue without using the compatibility mode. I'll see if I can reproduce it locally. Code available here, and stackblitz here. EDIT: In my case, the problem is that I'm using custom elements in my svelte configuration: compilerOptions: {
customElement: true,
}, |
Beta Was this translation helpful? Give feedback.
-
|
If someone wants to look into this and add undefined checks (in places they really shouldn't need to be), then I will consider merging a PR to support compat mode |
Beta Was this translation helpful? Give feedback.
-
|
having an error related to this. but on our end, it happens on Dialog component "svelte": "^5.35.2",
"bits-ui": "^2.8.10",
|
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi, didn't want to raise a bug until I was sure.
Variously, our dropdowns have started throwing an error when an item is selected and the dropdown closes.
onCloseAutoFocus.current is not a functionLooking at the code from console output, the crash happens here:
bits-ui/packages/bits-ui/src/lib/bits/utilities/focus-scope/use-focus-scope.svelte.ts
Line 199 in e46355b
I am guessing from where the
handleClosefunction is called that the param to that function is expected to sometimes benull, but.currentis called on it regardless.I'm very unfamiliar with the code base and so could be completely off. I'm not yet able to reproduce, but I will try to make one if you need.
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions