From 3990f2c1b7f3c89469341044b2a5bad4a8a8fab0 Mon Sep 17 00:00:00 2001
From: Andres Rosado <andres.rosado@gmail.com>
Date: Fri, 23 Aug 2019 17:27:25 -0400
Subject: [PATCH 1/4] Adding the setting to change the name of the SSO Login
 link.

---
 inc/admin/namespace.php | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/inc/admin/namespace.php b/inc/admin/namespace.php
index ef87c4f..66422c3 100644
--- a/inc/admin/namespace.php
+++ b/inc/admin/namespace.php
@@ -131,6 +131,7 @@ function get_sso_settings( $option = null ) {
 		'sso_enabled'           => '',
 		'sso_debug'             => 0,
 		'sso_sp_base'           => is_sso_enabled_network_wide() ? get_home_url( get_network()->site_id, '/' ) : home_url( '/' ),
+		'sso_login_name'        => 'SSO Login',
 		'sso_role_management'   => '',
 		'sso_whitelisted_hosts' => '',
 		'sso_idp_metadata'      => '',
@@ -189,6 +190,14 @@ function settings_fields() {
 		<?php
 	}, $settings_section, 'sso_settings' );
 
+	register_setting( $settings_section, 'sso_login_name' );
+	add_settings_field( 'sso_login_name', __( 'SSO Login Link Name', 'wp-simple-saml' ), function () use ( $options ) {
+		$value   = $options['sso_login_name'];
+		?>
+		<input type="text" name="sso_login_name" id="sso_login_name" value="<?php echo esc_html( $value ); ?>" placeholder="SSO Login">
+		<?php
+	}, $settings_section, 'sso_settings' );
+
 	register_setting( $settings_section, 'sso_sp_base', 'sanitize_url' );
 	add_settings_field( 'sso_sp_base', __( 'SSO Base URL', 'wp-simple-saml' ), function () use ( $options ) {
 		$value   = $options['sso_sp_base'];
@@ -335,6 +344,10 @@ function save_network_settings_fields() {
 		delete_site_option( 'sso_debug' ); // WPCS input var ok
 	}
 
+	if ( isset( $_POST['sso_login_name'] ) ) { // WPCS input var ok
+		update_site_option( 'sso_login_name', esc_html( wp_unslash( $_POST['sso_login_name'] ) ) ); // WPCS input var ok
+	}
+
 	if ( isset( $_POST['sso_sp_base'] ) ) { // WPCS input var ok
 		update_site_option( 'sso_sp_base', esc_url_raw( wp_unslash( $_POST['sso_sp_base'] ) ) ); // WPCS input var ok
 	}

From dc88d9495fc29d5c8c4181c8f092f7bd5abd6c5c Mon Sep 17 00:00:00 2001
From: Andres Rosado <andres.rosado@gmail.com>
Date: Fri, 23 Aug 2019 17:27:59 -0400
Subject: [PATCH 2/4] Reads the settings to give the name to the SSO Login
 link.

---
 inc/namespace.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/inc/namespace.php b/inc/namespace.php
index c9d732a..94136e8 100644
--- a/inc/namespace.php
+++ b/inc/namespace.php
@@ -139,7 +139,7 @@ function login_form_link() {
 		 *
 		 * @return string Text to be used for the login button
 		 */
-		esc_html( apply_filters( 'wpsimplesaml_log_in_text', __( 'SSO Login', 'wp-simple-saml' ) ) )
+		esc_html( apply_filters( 'wpsimplesaml_log_in_text', __( Admin\get_sso_settings( 'sso_login_name' ), 'wp-simple-saml' ) ) )
 	);
 
 	echo $output; // WPCS: xss ok

From 93a985b81deac5d5c241bb49f087797423186f96 Mon Sep 17 00:00:00 2001
From: Andres Rosado <andres.rosado@gmail.com>
Date: Fri, 23 Aug 2019 19:06:43 -0400
Subject: [PATCH 3/4] Fixing to coding standards.

---
 inc/admin/namespace.php | 2 +-
 inc/namespace.php       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/inc/admin/namespace.php b/inc/admin/namespace.php
index 66422c3..169eeb6 100644
--- a/inc/admin/namespace.php
+++ b/inc/admin/namespace.php
@@ -192,7 +192,7 @@ function settings_fields() {
 
 	register_setting( $settings_section, 'sso_login_name' );
 	add_settings_field( 'sso_login_name', __( 'SSO Login Link Name', 'wp-simple-saml' ), function () use ( $options ) {
-		$value   = $options['sso_login_name'];
+		$value = $options['sso_login_name'];
 		?>
 		<input type="text" name="sso_login_name" id="sso_login_name" value="<?php echo esc_html( $value ); ?>" placeholder="SSO Login">
 		<?php
diff --git a/inc/namespace.php b/inc/namespace.php
index 94136e8..d6ae01a 100644
--- a/inc/namespace.php
+++ b/inc/namespace.php
@@ -139,7 +139,7 @@ function login_form_link() {
 		 *
 		 * @return string Text to be used for the login button
 		 */
-		esc_html( apply_filters( 'wpsimplesaml_log_in_text', __( Admin\get_sso_settings( 'sso_login_name' ), 'wp-simple-saml' ) ) )
+		esc_html( apply_filters( 'wpsimplesaml_log_in_text', Admin\get_sso_settings( 'sso_login_name' ) ) )
 	);
 
 	echo $output; // WPCS: xss ok

From 2cbfedde1bd70fde0c4f82639c50ba5ad4502810 Mon Sep 17 00:00:00 2001
From: Andres Rosado <andresrs@users.noreply.github.com>
Date: Sat, 24 Aug 2019 14:57:28 -0400
Subject: [PATCH 4/4] Using `esc_attr` instead of `esc_html`

It's the correct way to handle text attributes.
---
 inc/admin/namespace.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/inc/admin/namespace.php b/inc/admin/namespace.php
index 169eeb6..50d6d52 100644
--- a/inc/admin/namespace.php
+++ b/inc/admin/namespace.php
@@ -194,7 +194,7 @@ function settings_fields() {
 	add_settings_field( 'sso_login_name', __( 'SSO Login Link Name', 'wp-simple-saml' ), function () use ( $options ) {
 		$value = $options['sso_login_name'];
 		?>
-		<input type="text" name="sso_login_name" id="sso_login_name" value="<?php echo esc_html( $value ); ?>" placeholder="SSO Login">
+		<input type="text" name="sso_login_name" id="sso_login_name" value="<?php echo esc_attr( $value ); ?>" placeholder="SSO Login">
 		<?php
 	}, $settings_section, 'sso_settings' );