Skip to content

Fix: StableDiffusionXLControlNetAdapterInpaintPipeline incorrectly inherited StableDiffusionLoraLoaderMixin #11357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025

Conversation

Kazuki-Yoda
Copy link
Contributor

@Kazuki-Yoda Kazuki-Yoda commented Apr 18, 2025

What does this PR do?

Fixes the community pipeline for T2I-Adapter StableDiffusionXLControlNetAdapterInpaintPipeline implemented in pipeline_stable_diffusion_xl_controlnet_adapter_inpaint.py, which incorrectly inherited StableDiffusionLoraLoaderMixin instead of StableDiffusionXLLoraLoaderMixin, although this pipeline uses SDXL, not SD1.5.

class StableDiffusionXLControlNetAdapterInpaintPipeline(
DiffusionPipeline, StableDiffusionMixin, FromSingleFileMixin, StableDiffusionLoraLoaderMixin
):

On the other hand, StableDiffusionXLControlNetAdapterPipeline (also implements T2I-Adapter but for txt2img) correctly inherited StableDiffusionXLLoraLoaderMixin.

class StableDiffusionXLControlNetAdapterPipeline(
DiffusionPipeline,
StableDiffusionMixin,
FromSingleFileMixin,
StableDiffusionXLLoraLoaderMixin,
TextualInversionLoaderMixin,
):

This bug was originally introduced by this PR #8981

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sayakpaul, @yiyixuxu, please review it when you have time 🙏

`StableDiffusionXLControlNetAdapterInpaintPipeline`
used to incorrectly inherit
`StableDiffusionLoraLoaderMixin`
instead of `StableDiffusionXLLoraLoaderMixin`
@Kazuki-Yoda Kazuki-Yoda marked this pull request as ready for review April 18, 2025 04:10
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu yiyixuxu merged commit ef47726 into huggingface:main Apr 18, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants