Skip to content

Commit 6e44f16

Browse files
Mishignsarrazin
authored andcommitted
Updates from code reviews
Co-authored-by: Nathan Sarrazin <sarrazin.nathan@gmail.com>
1 parent 5d4939c commit 6e44f16

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

src/lib/components/UploadBtn.svelte

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66
export let classNames = "";
77
export let multimodal = false;
88
export let files: File[];
9-
export let uploadPdfStatus: PdfUploadStatus;
10-
9+
export let uploadPdfStatus: PdfUploadStatus | undefined = undefined;
1110
const accept = multimodal ? "image/*,.pdf" : ".pdf";
1211
const label = multimodal ? "Upload image or PDF" : "Upload PDF";
1312
let fileInput: HTMLInputElement;

src/lib/components/chat/ChatWindow.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
export let RAGMessages: RAGUpdate[] = [];
3535
export let preprompt: string | undefined = undefined;
3636
export let files: File[] = [];
37-
export let uploadPdfStatus: PdfUploadStatus;
37+
export let uploadPdfStatus: PdfUploadStatus | undefined = undefined;
3838
3939
$: isReadOnly = !models.some((model) => model.id === currentModel.id);
4040

src/routes/conversation/[id]/upload-pdf/+server.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ export async function POST({ request, params, locals }) {
2020

2121
const formData = await request.formData();
2222
const file = formData.get("pdf"); // 'pdf' is the name used in FormData on the frontend
23+
if (!file || typeof file === "string") {
24+
throw error(400, "No file provided");
25+
}
2326
const data = new Uint8Array(await file.arrayBuffer());
2427
const pdf = await getDocument({ data }).promise;
2528

@@ -28,7 +31,7 @@ export async function POST({ request, params, locals }) {
2831
for (let i = 1; i <= Math.min(pdf.numPages, N_MAX_PAGES); i++) {
2932
const page = await pdf.getPage(i);
3033
const content = await page.getTextContent();
31-
text += content.items.map((item) => item.str).join(" ");
34+
text += content.items.map((item) => (item as { str?: string }).str ?? "").join(" ");
3235
}
3336

3437
const textChunks = chunk(text, CHUNK_CAR_LEN);

0 commit comments

Comments
 (0)