[Mongo] Optimize reports collection query (v2) (#834)

* [Mongo] Optimize `reports` collection query (#832)

* [Mongo] Optimize `reports` collection query

* perform reports query only once

* rm unused async

* keep both indices

* correct Objectid comparison

Author: Mishig

src/lib/server/database.ts

@@ -86,4 +86,5 @@ client.on("open", () => {
 	assistants.createIndex({ featured: 1, userCount: -1 }).catch(console.error);
 	assistants.createIndex({ modelId: 1, userCount: -1 }).catch(console.error);
 	reports.createIndex({ assistantId: 1 }).catch(console.error);
+	reports.createIndex({ createdBy: 1, assistantId: 1 }).catch(console.error);
 });

src/routes/settings/+layout.server.ts

@@ -1,6 +1,7 @@
 import { collections } from "$lib/server/database";
 import { ObjectId } from "mongodb";
 import type { LayoutServerLoad } from "./$types";
+import type { Report } from "$lib/types/Report";
 
 export const load = (async ({ locals, parent }) => {
 	const { settings } = await parent();
@@ -12,20 +13,22 @@ export const load = (async ({ locals, parent }) => {
 		})
 		.toArray();
 
+	let reportsByUser: string[] = [];
+	const createdBy = locals.user?._id ?? locals.sessionId;
+	if (createdBy) {
+		const reports = await collections.reports
+			.find<Pick<Report, "assistantId">>({ createdBy }, { projection: { _id: 0, assistantId: 1 } })
+			.toArray();
+		reportsByUser = reports.map((r) => r.assistantId.toString());
+	}
+
 	return {
-		assistants: await Promise.all(
-			assistants.map(async (el) => ({
-				...el,
-				_id: el._id.toString(),
-				createdById: undefined,
-				createdByMe:
-					el.createdById.toString() === (locals.user?._id ?? locals.sessionId).toString(),
-				reported:
-					(await collections.reports.countDocuments({
-						assistantId: el._id,
-						createdBy: locals.user?._id ?? locals.sessionId,
-					})) > 0,
-			}))
-		),
+		assistants: assistants.map((el) => ({
+			...el,
+			_id: el._id.toString(),
+			createdById: undefined,
+			createdByMe: el.createdById.toString() === (locals.user?._id ?? locals.sessionId).toString(),
+			reported: reportsByUser.includes(el._id.toString()),
+		})),
 	};
 }) satisfies LayoutServerLoad;

src/routes/settings/assistants/[assistantId]/+page.server.ts

@@ -57,8 +57,8 @@ export const actions: Actions = {
 	report: async ({ request, params, locals, url }) => {
 		// is there already a report from this user for this model ?
 		const report = await collections.reports.findOne({
-			assistantId: new ObjectId(params.assistantId),
 			createdBy: locals.user?._id ?? locals.sessionId,
+			assistantId: new ObjectId(params.assistantId),
 		});
 
 		if (report) {