Merge pull request #92 from htmlacademy/fix/input-req-label

Fix input-req-label

Author: nikolai-shabalin

rules/input-req-label/README.md

@@ -39,4 +39,5 @@
 
 <input type="hidden" value="dinosaur">
 
+<input type="submit" value="submit">
 ```

rules/input-req-label/fixture/error.html

@@ -0,0 +1,5 @@
+<!-- without a value for the value attribute -->
+<input type="submit" value="">
+
+<!-- without the value attribute -->
+<input type="submit">

rules/input-req-label/fixture/success.html

@@ -0,0 +1,2 @@
+<!-- [type="submit"] with the specified value in the value attribute -->
+<input type="submit" value="Отправить">

rules/input-req-label/index.js

@@ -28,6 +28,7 @@ module.exports = {
     if (!is_tag_node(node) || !['input', 'label'].includes(node.name)) {
       return;
     }
+
     // if it's a label with a 'for', store that value
     if (node.name === 'label') {
       const for_attribute = attribute_value(node, 'for');
@@ -37,11 +38,10 @@ module.exports = {
       return;
     }
 
-    if (attribute_has_value(node, 'type', 'hidden')) {
-      return;
-    }
+    const isHiddenOrSubmitType = (input) => ['hidden', 'submit'].some((type) => attribute_has_value(input, 'type', type));
+    const hasAriaLabel = has_non_empty_attribute(node, 'aria-label');
 
-    if (has_non_empty_attribute(node, 'aria-label')) {
+    if (isHiddenOrSubmitType(node) || hasAriaLabel) {
       return;
     }