Skip to content

Commit 5c98dde

Browse files
authored
Merge pull request #17 from htmlacademy/feature/move-to-4
Feature/move to 4
2 parents 4fec885 + 23fe9ed commit 5c98dde

File tree

7 files changed

+22
-13
lines changed

7 files changed

+22
-13
lines changed

README.md

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ $ npm install --save-dev eslint eslint-config-htmlacademy
1414

1515
Once the `eslint-config-htmlacademy` package is installed, you can use it by specifying `htmlacademy` in the [`extends`](http://eslint.org/docs/user-guide/configuring#extending-configuration-files) section of your [ESLint configuration](http://eslint.org/docs/user-guide/configuring).
1616

17-
For validating ECMAScript 5 project use `es5` version:
17+
For validating **ECMAScript 5** project use `es5` version:
1818

19-
```js
19+
```json
2020
{
2121
"extends": "htmlacademy/es5",
2222
"rules": {
@@ -25,10 +25,17 @@ For validating ECMAScript 5 project use `es5` version:
2525
}
2626
```
2727

28-
For validating ECMAScript 6 project use `es6` version:
28+
For validating **ECMAScript 2015 (ES6)** project use `es6` version:
2929

30-
```js
30+
```json
3131
{
32+
"parserOptions": {
33+
"ecmaVersion": 6,
34+
"sourceType": "module"
35+
},
36+
"env": {
37+
"es6": true
38+
},
3239
"extends": "htmlacademy/es6",
3340
"rules": {
3441
// Additional rules...

es5.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ module.exports = {
105105
SwitchCase: 1,
106106
// continuation indent
107107
VariableDeclarator: 1, // indent is multiplier * indent = 1 * 2
108-
MemberExpression: 2, // indent is multiplier * indent = 1 * 2
108+
MemberExpression: 2, // indent is multiplier * indent = 1 * 2
109109
FunctionDeclaration: {parameters: 2},
110110
FunctionExpression: {parameters: 2},
111111
CallExpression: {arguments: 2}

es6.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ module.exports = {
1111
'constructor-super': `error`, // eslint:recommended
1212
'generator-star-spacing': [`error`, `after`],
1313
'no-new-symbol': `error`, // eslint:recommended
14-
'no-this-before-super': `error`, // eslint:recommended
14+
'no-this-before-super': `error`, // eslint:recommended
1515
'no-var': `error`,
1616
'prefer-rest-params': `error`,
1717
'prefer-spread': `error`,

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,9 @@
4343
},
4444
"homepage": "https://github.com/htmlacademy/eslint-config-htmlacademy#readme",
4545
"peerDependencies": {
46-
"eslint": ">=3.9.0"
46+
"eslint": ">=4.2.0"
4747
},
4848
"devDependencies": {
49-
"babel-eslint": "7.1.1",
50-
"eslint": "3.10.2"
49+
"eslint": "4.2.0"
5150
}
5251
}

test/es5/eslint.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ module.exports = {
104104
SwitchCase: 1,
105105
// continuation indent
106106
VariableDeclarator: 1, // indent is multiplier * indent = 1 * 2
107-
MemberExpression: 1, // indent is multiplier * indent = 1 * 2
107+
MemberExpression: 1, // indent is multiplier * indent = 1 * 2
108108
FunctionDeclaration: {parameters: 2},
109109
FunctionExpression: {parameters: 2},
110110
CallExpression: {arguments: 2}

test/es6/.eslintrc.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
let config = require('../../es6');
2-
config.parser = 'babel-eslint';
1+
const config = require('../../es6');
2+
config.parserOptions = {
3+
ecmaVersion: 6,
4+
sourceType: 'module'
5+
};
36
config.env = {
47
'es6': true,
58
'browser': true,

test/es6/eslint.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ module.exports = {
1111
'constructor-super': `error`, // eslint:recommended
1212
'generator-star-spacing': [`error`, `after`],
1313
'no-new-symbol': `error`, // eslint:recommended
14-
'no-this-before-super': `error`, // eslint:recommended
14+
'no-this-before-super': `error`, // eslint:recommended
1515
'no-var': `error`,
1616
'prefer-rest-params': `error`,
1717
'prefer-spread': `error`,

0 commit comments

Comments
 (0)