Fix parse for non-first argument named out, move, or forward

Closes #1156

Author: hsutter

docs/cpp2/objects.md

@@ -101,17 +101,16 @@ In the above example, note the simple rule for branches: The local variable must
 
 ## <a id="heap"></a>Heap objects
 
-Objects can also be allocated on the heap using `#!cpp arena.new <T> (/*initializer, arguments*/)` where `arena` is any object that acts as a memory arena and provides a `#!cpp .new` function template. Two memory arena objects are provided in namespace `cpp2`:
+Objects can also be allocated on the heap using `#!cpp xxx.new <T> (/*initializer, arguments*/)` where `xxx` is any object that acts as a memory allocator and provides a `#!cpp .new` function template. Two memory allocators objects are provided in namespace `cpp2`:
 
 - `#!cpp unique.new<T>` calls `std::make_unique<T>` and returns a `std::unique_ptr<T>`.
 
 - `#!cpp shared.new<T>` calls `std::make_shared<T>` and returns a `std::shared_ptr<T>`.
 
-The default is `#!cpp unique.new` if you don't specify an arena object.
+The default is `#!cpp unique.new` if you don't specify an allocator object.
 
 For example (see [types](types.md) for more details about writing types):
 
-
 ``` cpp title="Heap allocation" hl_lines="3-6 10-11"
 f: () -> std::shared_ptr<widget>
 = {

regression-tests/test-results/version

@@ -1,5 +1,5 @@
 
-cppfront compiler v0.7.0   Build 9711:1018
+cppfront compiler v0.7.0   Build 9712:0834
 Copyright(c) Herb Sutter   All rights reserved
 
 SPDX-License-Identifier: CC-BY-NC-ND-4.0

source/build.info

@@ -1 +1 @@
-"9711:1018"
+"9712:0834"

source/lex.h

@@ -935,8 +935,7 @@ auto lex_line(
     //G     simple-hexadecimal-digit-sequence hexadecimal-digit
     //G
     //G hexadecimal-escape-sequence:
-    //G     '\x' hexadecimal-digit
-    //G     hexadecimal-escape-sequence hexadecimal-digit
+    //G     '\x' simple-hexadecimal-digit-sequence
     //G     '\x{' simple-hexadecimal-digit-sequence '}'
     //G
     auto peek_is_hexadecimal_escape_sequence = [&](int offset)

source/parse.h

@@ -6485,19 +6485,24 @@ class parser
         n->open_paren = open_paren;
         n->inside_initializer = inside_initializer;
 
-        if (auto dir = to_passing_style(curr());
-            (
-                dir == passing_style::out
-                || dir == passing_style::move
-                || dir == passing_style::forward
+        auto consume_optional_passing_style = [&] {
+            pass = passing_style::in;
+            if (auto dir = to_passing_style(curr());
+                (
+                    dir == passing_style::out
+                    || dir == passing_style::move
+                    || dir == passing_style::forward
+                    )
+                && peek(1)
+                && peek(1)->type() == lexeme::Identifier
                 )
-            && peek(1)
-            && peek(1)->type() == lexeme::Identifier
-            )
-        {
-            pass = dir;
-            next();
-        }
+            {
+                pass = dir;
+                next();
+            }
+        };
+
+        consume_optional_passing_style();
         auto x = expression();
 
         //  If this is an empty expression_list, we're done
@@ -6516,16 +6521,7 @@ class parser
                 break;
             }
 
-            pass = passing_style::in;
-            if (auto dir = to_passing_style(curr());
-                dir == passing_style::out
-                || dir == passing_style::move
-                || dir == passing_style::forward
-                )
-            {
-                pass = dir;
-                next();
-            }
+            consume_optional_passing_style();
             auto expr = expression();
             if (!expr) {
                 error("invalid text in expression list", true, {}, true);