Add diagnostic for non-object this member, closes #898

hsutter · hsutter · commit 09cfca5fd4aa · 2023-12-20T09:44:09.000-08:00
diff --git a/source/sema.h b/source/sema.h
@@ -1237,7 +1237,13 @@ class sema
             && n.parent_is_type()
             )
         {
-            assert(n.is_object());
+            if (!n.is_object()) {
+                errors.emplace_back(
+                    n.position(),
+                    "a member named 'this' declares a base subobject, and must be followed by a base type name"
+                );
+                return false;
+            }
 
             if (
                 !n.is_public()

Original file line number	Diff line number	Diff line change
`@@ -1237,7 +1237,13 @@ class sema`
`1237`	`1237`	`&& n.parent_is_type()`
`1238`	`1238`	`)`
`1239`	`1239`	`{`
`1240`		`- assert(n.is_object());`
	`1240`	`+ if (!n.is_object()) {`
	`1241`	`+ errors.emplace_back(`
	`1242`	`+ n.position(),`
	`1243`	`+ "a member named 'this' declares a base subobject, and must be followed by a base type name"`
	`1244`	`+ );`
	`1245`	`+ return false;`
	`1246`	`+ }`
`1241`	`1247`
`1242`	`1248`	`if (`
`1243`	`1249`	`!n.is_public()`