coll_base_util.c: ensure buffer is long enough

jsquyres · jsquyres · commit 9aab29a6cd92 · 2023-11-27T16:16:40.000-05:00
Ensure that a buffer is long enough to hold the trailing \0.

Signed-off-by: Jeff Squyres &lt;jeff@squyres.com&gt;
diff --git a/ompi/mca/coll/base/coll_base_util.c b/ompi/mca/coll/base/coll_base_util.c
@@ -11,6 +11,7 @@
  *                         All rights reserved.
  * Copyright (c) 2014-2020 Research Organization for Information Science
  *                         and Technology (RIST).  All rights reserved.
+ * Copyright (c) 2023      Jeffrey M. Squyres.  All rights reserved.
  * $COPYRIGHT$
  *
  * Additional copyrights may follow
@@ -398,7 +399,7 @@ int ompi_coll_base_file_getnext_long(FILE *fptr, int *fileline, long* val)
 
 int ompi_coll_base_file_getnext_string(FILE *fptr, int *fileline, char** val)
 {
-    char trash, token[32];
+    char trash, token[33];
     int rc;
 
     *val = NULL;  /* security in case we fail */

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@`
`11`	`11`	`* All rights reserved.`
`12`	`12`	`* Copyright (c) 2014-2020 Research Organization for Information Science`
`13`	`13`	`* and Technology (RIST). All rights reserved.`
	`14`	`+ * Copyright (c) 2023 Jeffrey M. Squyres. All rights reserved.`
`14`	`15`	`* $COPYRIGHT$`
`15`	`16`	`*`
`16`	`17`	`* Additional copyrights may follow`
`@@ -398,7 +399,7 @@ int ompi_coll_base_file_getnext_long(FILE fptr, int fileline, long* val)`
`398`	`399`
`399`	`400`	`int ompi_coll_base_file_getnext_string(FILE fptr, int fileline, char** val)`
`400`	`401`	`{`
`401`		`- char trash, token[32];`
	`402`	`+ char trash, token[33];`
`402`	`403`	`int rc;`
`403`	`404`
`404`	`405`	`val = NULL; / security in case we fail */`