Skip to content

Select not behaving correctly in Dialog #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CryptAlchemy opened this issue Jun 7, 2022 · 1 comment
Open

Select not behaving correctly in Dialog #468

CryptAlchemy opened this issue Jun 7, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@CryptAlchemy
Copy link
Contributor

CryptAlchemy commented Jun 7, 2022

Describe the bug
The Select element is not setting the correct max height when applying the menu$fixed={true} prop to it. The Select is contained within a Dialog.

To Reproduce
Open this Repl and scale your browser window vertically to be small, like on a phone. Open the dropdown menu and you'll see that it overflows off the screen.

Expected behavior
This REPL is a vanilla material-components-web implementation and how it should behave. Scale your window like before and open the dropdown; you'll see that the height scales correctly and the items are scrollable.

Desktop (please complete the following information):

  • OS: Windows 10 Pro (10.0.19044 Build 19044)
  • Browser Microsoft Edge (102.0.1245.30)
  • Version: @smui/select (^6.0.0-beta.16)

Thank You and Best Regards!

Final Notes
Trying to make the Select and the Dialog work together appropriately like in this issue.

@CryptAlchemy
Copy link
Contributor Author

Turns out that this is a duplicate of #242.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant