Skip to content

PDE_DATA problems on AARCH64 #65

@SkyWorld117

Description

@SkyWorld117

In xpmem_pfn.c I noticed the following lines:

#if LINUX_VERSION_CODE < KERNEL_VERSION(5,17,0)
#define pde_data(indoe) PDE_DATA(inode)
#elif LINUX_VERSION_CODE < KERNEL_VERSION(3,10,0)
#define pde_data(inode) ((PDE(inode)->data))
#endif

First, I believe #define pde_data(indoe) PDE_DATA(inode) is a typo?

Second, isn't if more logical if checking version below 3.10.0 instead (as below)?

#if LINUX_VERSION_CODE < KERNEL_VERSION(3,10,0)
#define pde_data(inode) ((PDE(inode)->data))
#elif LINUX_VERSION_CODE < KERNEL_VERSION(5,17,0)
#define pde_data(inode) PDE_DATA(inode)
#endif

Third, I tried to compile it on Rocky Linux release 9.3 (Blue Onyx) on AARCH64 with kernel version 5.14.0-362.18.1.el9_3.0.1.aarch64, it is already using pde_data instead of PDE_DATA

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions