hotfix: Remove TODO comments and implement backtrace checks for address line mapping in DXT_POSIX data handling

Author: jay-tau

drishti/handlers/darshan_util.py

@@ -432,9 +432,8 @@ def name_records(self) -> Dict[int, str]:
 
     @property
     def dxt_posix_df(self) -> Optional[pd.DataFrame]:
-        # TODO
-        # if parser.args.backtrace is False:
-        #     return None
+        if parser.args.backtrace is False:
+            return None
         assert "DXT_POSIX" in self.modules, "Missing DXT_POSIX module"
         dxt_posix_df = pd.DataFrame(self.report.records["DXT_POSIX"].to_df())
         return dxt_posix_df
@@ -447,10 +446,9 @@ def dxt_posix_read_df(self) -> Optional[pd.DataFrame]:
         df = self.dxt_posix_df
         assert df is not None, "Should be handled by parser.args.backtrace check"
 
-        # TODO
-        # if "address_line_mapping" not in df:
-        #     parser.args.backtrace = False
-        #     return None
+        if "address_line_mapping" not in df:
+            parser.args.backtrace = False
+            return None
 
         read_id = []
         read_rank = []
@@ -506,10 +504,9 @@ def dxt_posix_write_df(self) -> Optional[pd.DataFrame]:
         df = self.dxt_posix_df
         assert df is not None, "Should be handled by parser.args.backtrace check"
 
-        # TODO
-        # if "address_line_mapping" not in df:
-        #     parser.args.backtrace = False
-        #     return None
+        if "address_line_mapping" not in df:
+            parser.args.backtrace = False
+            return None
 
         write_id = []
         write_rank = []

drishti/handlers/handle_darshan.py

@@ -212,13 +212,9 @@ def handler():
         if "DXT_POSIX" in report.records:
             dxt_posix = report.records["DXT_POSIX"].to_df()
             dxt_posix = pd.DataFrame(dxt_posix)
-            if False:
-            # if "address_line_mapping" not in dxt_posix:
-                # parser.args.backtrace = False # TODO
-                print("Upper")
-                pass
+            if "address_line_mapping" not in dxt_posix:
+                parser.args.backtrace = False
             else:
-                print("ENTERED")
                 read_id = []
                 read_rank = []
                 read_length = []
@@ -428,8 +424,6 @@ def handler():
 
 
         # module.check_small_operation(total_reads, total_reads_small, total_writes, total_writes_small, detected_files, modules, file_map, dxt_posix, dxt_posix_read_data, dxt_posix_write_data)
-        parser.args.backtrace = True # TODO
-
         module.check_small_operation(
             total_reads=darshan_file_obj.io_stats.get_module_ops(ModuleType.POSIX, "read"),
             total_reads_small=darshan_file_obj.posix_small_io.read,