Skip to content

Commit 494e276

Browse files
ffmpeg-for-homebridge is not being utilized (#480)
* ffmpeg-for-homebridge is not being utilized When debugging why I could not use the proper audio codec provided by ffmpeg-for-homebridge found that it was using the OS installed version. * CHANGELOG and README * README * Update CHANGELOG.md * Update package.json Co-authored-by: Donavan Becker <9875439+donavanbecker@users.noreply.github.com>
1 parent 6d7da57 commit 494e276

File tree

4 files changed

+20
-8
lines changed

4 files changed

+20
-8
lines changed

CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# Change Log
2+
3+
All notable changes to this project will be documented in this file. This project uses [Semantic Versioning](https://semver.org/).
4+
5+
6+
## v1.0.0 (2020-05-11)
7+
8+
### Breaking Changes
9+
10+
* We are now bundling static ffmpeg binaries for Homebridge with support for audio (libfdk-aac) and hardware decoding (h264_omx) for most major platforms. Details are [here](https://github.com/homebridge/ffmpeg-for-homebridge)
11+
* And are defaulting to use the supplied version unless a different version is specified with the `videoProcessor` configuration option.
12+
13+
### Notable Changes

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
<a href="https://www.npmjs.com/package/homebridge-camera-ffmpeg"><img title="npm version" src="https://badgen.net/npm/v/homebridge-camera-ffmpeg" ></a>
88
<a href="https://www.npmjs.com/package/homebridge-camera-ffmpeg"><img title="npm downloads" src="https://badgen.net/npm/dt/homebridge-camera-ffmpeg" ></a>
99

10-
<p><a href="https://www.ffmpeg.org">FFmpeg</a> plugin for
11-
<a href="https://homebridge.io">Homebridge</a>.
10+
<p><a href="https://www.ffmpeg.org">FFmpeg</a> plugin for
11+
<a href="https://homebridge.io">Homebridge</a>.
1212
</p>
1313

1414
</span>
@@ -21,7 +21,7 @@
2121
- Run Homebridge
2222
- Add extra camera accessories in Home app. The setup code is the same as homebridge.
2323

24-
- Install via Homebridge Web UI
24+
- Install via Homebridge Web UI
2525
- Search for `Camera FFmpeg` on the plugin screen of [config-ui-x](https://github.com/oznu/homebridge-config-ui-x) .
2626
- Click install.
2727

@@ -90,8 +90,8 @@ Example with manufacturer, model, serial number and firmware set:
9090
* `maxBitrate` is the maximum bit rate of the stream in kbit/s, default `300`
9191
* `preserveRatio` can be set to either `W` or `H` with respective obvious meanings, all other values have no effect
9292
* `vcodec` If you're running on a RPi with the omx version of ffmpeg installed, you can change to the hardware accelerated video codec with this option, default `libx264`
93-
* `audio` can be set to true to enable audio streaming from camera. To use audio ffmpeg must be compiled with --enable-libfdk-aac, see https://github.com/KhaosT/homebridge-camera-ffmpeg/wiki, default `false`. Many ffmpeg binaries are not compiled with libfdk-aac, and to work around this issue, force the OPUS codec:
94-
`"acodec": "libopus"`
93+
* `audio` can be set to true to enable audio streaming from camera, default `false`.
94+
* `acodec` Default audio codec is `libfdk_aac` and is enabled in the bundled ffmpeg version.
9595
* `packetSize` If audio or video is choppy try a smaller value, set to a multiple of 188, default `1316`
9696
* `vflip` Flips the stream vertically, default `false`
9797
* `hflip` Flips the stream horizontally, default `false`

index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ ffmpegPlatform.prototype.configureAccessory = function(accessory) {
3535

3636
ffmpegPlatform.prototype.didFinishLaunching = function() {
3737
var self = this;
38-
var videoProcessor = self.config.videoProcessor || 'ffmpeg';
3938
var interfaceName = self.config.interfaceName || '';
4039

4140
if (self.config.cameras) {
@@ -79,7 +78,7 @@ ffmpegPlatform.prototype.didFinishLaunching = function() {
7978
.on('set', _Motion.bind(cameraAccessory));
8079
}
8180

82-
var cameraSource = new FFMPEG(hap, cameraConfig, self.log, videoProcessor, interfaceName);
81+
var cameraSource = new FFMPEG(hap, cameraConfig, self.log, self.config.videoProcessor, interfaceName);
8382
cameraAccessory.configureCameraSource(cameraSource);
8483
configuredAccessories.push(cameraAccessory);
8584
});

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"displayName": "Homebridge Camera FFmpeg",
33
"name": "homebridge-camera-ffmpeg",
4-
"version": "0.1.19",
4+
"version": "1.0.0",
55
"description": "ffmpeg plugin for homebridge: https://github.com/nfarina/homebridge",
66
"license": "ISC",
77
"keywords": [

0 commit comments

Comments
 (0)