Do not backup add-on being uninstalled (#5917)

Author: agners

supervisor/addons/addon.py

@@ -1335,6 +1335,13 @@ def _addon_backup(
 
         wait_for_start: asyncio.Task | None = None
 
+        # Refuse to backup if add-on is unknown (e.g. has been uninstalled by the user
+        # since the backup got started).
+        if self.state == AddonState.UNKNOWN:
+            raise AddonsError(
+                f"Add-on {self.slug} is not installed, cannot backup!", _LOGGER.error
+            )
+
         data = {
             ATTR_USER: self.persist,
             ATTR_SYSTEM: self.data,

tests/addons/test_addon.py

@@ -102,7 +102,7 @@ async def test_addon_state_listener(coresys: CoreSys, install_addon_ssh: Addon)
     with patch.object(DockerAddon, "attach"):
         await install_addon_ssh.load()
 
-    assert install_addon_ssh.state == AddonState.UNKNOWN
+    assert install_addon_ssh.state == AddonState.STOPPED
 
     with patch.object(Addon, "watchdog_container"):
         _fire_test_event(coresys, f"addon_{TEST_ADDON_SLUG}", ContainerState.RUNNING)

tests/conftest.py

@@ -40,6 +40,7 @@
     ATTR_TYPE,
     ATTR_VERSION,
     REQUEST_FROM,
+    AddonState,
     CoreState,
 )
 from supervisor.coresys import CoreSys
@@ -615,6 +616,7 @@ async def install_addon_ssh(coresys: CoreSys, repository):
     coresys.addons.data._data = coresys.addons.data._schema(coresys.addons.data._data)
 
     addon = Addon(coresys, store.slug)
+    addon.state = AddonState.STOPPED
     coresys.addons.local[addon.slug] = addon
     yield addon
 
@@ -627,6 +629,7 @@ async def install_addon_example(coresys: CoreSys, repository):
     coresys.addons.data._data = coresys.addons.data._schema(coresys.addons.data._data)
 
     addon = Addon(coresys, store.slug)
+    addon.state = AddonState.STOPPED
     coresys.addons.local[addon.slug] = addon
     yield addon