Layout does not use active_tools options

[MarcSkovMadsen]

I'm trying to create a Panel example for scikit-image.

I have two images (before+after). I want them to share the toolbar and have box_zoom as the default active tool.

But I cannot achieve that.

The first two rows below do not have box_zoom as the active_tool even though I've specified it.

The third has box_zoom as the active_tool but does not share the toolbar.

import holoviews as hv
import panel as pn
from skimage import data, filters

image = data.coins()
edges = filters.sobel(image)*256

bounds = (-1, -1, 1, 1)

before_img = hv.Image(image, bounds=bounds).apply.opts(
    cmap="binary_r", height=400, width=400, title="Before", active_tools=["box_zoom"], tools=["hover"]
)
after_img = hv.Image(edges, bounds=bounds).apply.opts(
    cmap="binary_r", height=400, width=400, title="After", active_tools=["box_zoom"], tools=["hover"], colorbar=True
)
layout=(before_img+after_img).apply.opts(active_tools=["box_zoom"])

pn.Column(
    pn.panel(before_img+after_img, sizing_mode="fixed"),
    pn.panel(layout, sizing_mode="fixed"),
    pn.Row(before_img, after_img, sizing_mode="fixed"),
).servable()

[jbednar]

I can reproduce that, though I don't know if the problem is in HoloViews or the underlying Bokeh code.

[MarcSkovMadsen]

Just got hit by this again. There is also a user reporting the issue on Discourse: https://discourse.holoviz.org/t/how-to-set-active-tools-for-layout/2006

[MarcSkovMadsen]

Just got hit by this again trying to create a dashboard with crossfiltering for Panel tutorials.

import holoviews as hv
import numpy as np
import pandas as pd
import panel as pn
from bokeh.models.formatters import NumeralTickFormatter

pn.extension(sizing_mode="stretch_width")

ACCENT = "teal"

SHORT_NAMES = {
    "Changzhou Railcar Propulsion Engineering Research and Development Center": "Changzhou",
    "Siemens Gamesa Renewable Energy": "Siemens Gamesa",
}

@pn.cache()
def _download_data():
    return pd.read_csv("https://assets.holoviz.org/panel/tutorials/turbines.csv.gz")

@pn.cache
def get_data():
    data = _download_data()
    mask = data.t_manu.isin(list(SHORT_NAMES))
    data.loc[mask, "t_manu"] = data.loc[mask, "t_manu"].map(SHORT_NAMES)
    data.t_cap = data.t_cap/10**6
    return data

# @pn.cache
def plot_with_crossfilter():
    data = get_data()

    # Define shared dataset
    ds = hv.Dataset(data, ["t_manu", "p_year", "t_cap"], "t_cap")
    
    # Create plots
    ds_by_year = ds.aggregate("p_year", function=np.sum).sort("p_year")
    ds_by_manufacturer = ds.aggregate("t_manu", function=np.sum).sort("t_cap", reverse=True)
    formatter = NumeralTickFormatter(format="0,0")
    plot_by_year = hv.Bars(ds_by_year, ("p_year", "Year"), ("t_cap", "Capacity (GW)")).opts(
        responsive=True, xrotation=90, yformatter=formatter, color=ACCENT, tools=["hover"], active_tools=['box_select']
    )
    plot_by_manufacturer = hv.Bars(ds_by_manufacturer, ("t_manu", "Manufacturer"), ("t_cap", "Capacity (GW)")).opts(
        responsive=True, xrotation=90, yformatter=formatter, color=ACCENT, tools=["hover"], active_tools=['box_select']
    )

    # Link plots
    layout = (plot_by_year + plot_by_manufacturer).cols(1)
    selections = hv.link_selections(layout)
    return selections

cross_filter_plot = plot_with_crossfilter()

pn.template.FastListTemplate(
    title="Windturbine Dashboard with Crossfiltering",
    main=[cross_filter_plot],
    main_layout=None,
    accent=ACCENT,
).servable()

[philippjfr]

Looked into this, seems like this needs a fix in Bokeh first: bokeh/bokeh#8766

[philippjfr]

For future reference, here's a modified version of our merge_tools function which tries to set the active_<gesture> properties:

def merge_tools(plot_grid, *, disambiguation_properties=None, hide_toolbar=False):
    """
    Merges tools defined on a grid of plots into a single toolbar.
    All tools of the same type are merged unless they define one
    of the disambiguation properties. By default `name`, `icon`, `tags`
    and `description` can be used to prevent tools from being merged.
    """
    tools = []
    active = {}
    for row in plot_grid:
        for item in row:
            if isinstance(item, LayoutDOM):
                for p in item.select(dict(type=Plot)):
                    tools.extend(p.toolbar.tools)
                    for p, t in p.toolbar.properties_with_values().items():
                        if p.startswith('active_'):
                            active[p] = t
            if hide_toolbar and hasattr(item, 'toolbar_location'):
                item.toolbar_location = None
            if isinstance(item, GridPlot):
                item.toolbar_location = None

    def merge(tool, group):
        if issubclass(tool, (SaveTool, CopyTool, ExamineTool, FullscreenTool)):
            return tool()
        else:
            return None

    if not disambiguation_properties:
        disambiguation_properties = {'name', 'icon', 'tags', 'description'}

    ignore = set()
    for tool in tools:
        for p in tool.properties_with_values():
            if p not in disambiguation_properties:
                ignore.add(p)

    grouped_tools = group_tools(tools, merge=merge, ignore=ignore)
    toolbar_props = {'tools': grouped_tools} if grouped_tools else {}
    for p, tool in active.items():
        if tool == 'auto':
            continue
        for tool_proxy in grouped_tools:
            if isinstance(tool_proxy, ToolProxy) and tool in tool_proxy.tools:
                toolbar_props[p] = tool_proxy
            elif tool is tool_proxy:
                toolbar_props[p] = tool
    return Toolbar(**toolbar_props)