Use dedicated send and receive buffer to allow simultaneous read/write

Author: Jurrie

modules/core/src/main/java/com/illposed/osc/transport/channel/OSCDatagramChannel.java

@@ -52,58 +52,60 @@ public OSCDatagramChannel(
 		this.serializerBuilder = serializerAndParserBuilder;
 	}
 
-	public OSCPacket read(final ByteBuffer buffer) throws IOException, OSCParseException {
+	public OSCPacket read(final ByteBuffer recvBuffer) throws IOException, OSCParseException {
 
 		boolean completed = false;
 		OSCPacket oscPacket;
 		try {
 			begin();
 
-			buffer.clear();
+			recvBuffer.clear();
 			// NOTE From the doc of `read()` and `receive()`:
 			// "If there are fewer bytes remaining in the buffer
 			// than are required to hold the datagram
 			// then the remainder of the datagram is silently discarded."
 			if (underlyingChannel.isConnected()) {
-				underlyingChannel.read(buffer);
+				underlyingChannel.read(recvBuffer);
 			} else {
-				underlyingChannel.receive(buffer);
+				underlyingChannel.receive(recvBuffer);
 			}
 //			final int readBytes = buffer.position();
 //			if (readBytes == buffer.capacity()) {
 //				// TODO In this case it is very likely that the buffer was actually too small, and the remainder of the datagram/packet was silently discarded. We might want to give a warning, like throw an exception in this case, but whether this happens should probably be user configurable.
 //			}
-			buffer.flip();
-			if (buffer.limit() == 0) {
-				throw new OSCParseException("Received a packet without any data", buffer);
+			recvBuffer.flip();
+			if (recvBuffer.limit() == 0) {
+				throw new OSCParseException("Received a packet without any data", recvBuffer);
 			} else {
-				oscPacket = parser.convert(buffer);
+				oscPacket = parser.convert(recvBuffer);
 				completed = true;
 			}
+			recvBuffer.flip();
 		} finally {
 			end(completed);
 		}
 
 		return oscPacket;
 	}
 
-	public void send(final ByteBuffer buffer, final OSCPacket packet, final SocketAddress remoteAddress) throws IOException, OSCSerializeException {
+	public void send(final ByteBuffer sendBuffer, final OSCPacket packet, final SocketAddress remoteAddress) throws IOException, OSCSerializeException {
 
 		boolean completed = false;
 		try {
 			begin();
 
-			final OSCSerializer serializer = serializerBuilder.buildSerializer(new BufferBytesReceiver(buffer));
-			buffer.rewind();
+			final OSCSerializer serializer = serializerBuilder.buildSerializer(new BufferBytesReceiver(sendBuffer));
+			sendBuffer.rewind();
 			serializer.write(packet);
-			buffer.flip();
+			sendBuffer.flip();
 			if (underlyingChannel.isConnected()) {
-				underlyingChannel.write(buffer);
+				underlyingChannel.write(sendBuffer);
 			} else if (remoteAddress == null) {
 				throw new IllegalStateException("Not connected and no remote address is given");
 			} else {
-				underlyingChannel.send(buffer, remoteAddress);
+				underlyingChannel.send(sendBuffer, remoteAddress);
 			}
+			sendBuffer.flip();
 			completed = true;
 		} finally {
 			end(completed);

modules/core/src/main/java/com/illposed/osc/transport/udp/UDPTransport.java

@@ -34,7 +34,8 @@ public class UDPTransport implements Transport {
 	 * incoming datagram data size.
 	 */
 	public static final int BUFFER_SIZE = 65507;
-	private final ByteBuffer buffer = ByteBuffer.allocate(BUFFER_SIZE);
+	private final ByteBuffer recvBuffer = ByteBuffer.allocate(BUFFER_SIZE);
+	private final ByteBuffer sendBuffer = ByteBuffer.allocate(BUFFER_SIZE);
 
 	private final SocketAddress local;
 	private final SocketAddress remote;
@@ -131,12 +132,12 @@ public void close() throws IOException {
 
 	@Override
 	public void send(final OSCPacket packet) throws IOException, OSCSerializeException {
-		oscChannel.send(buffer, packet, remote);
+		oscChannel.send(sendBuffer, packet, remote);
 	}
 
 	@Override
 	public OSCPacket receive() throws IOException, OSCParseException {
-		return oscChannel.read(buffer);
+		return oscChannel.read(recvBuffer);
 	}
 
 	@Override